Extraobjective icons on map for quests that are complete are re-drawn after a /reload
Cabro opened this issue · 17 comments
This is becoming visible each time you log a different char, so the chances for this bug to happen are pretty high, i'd say :(
I think I also remember mentioning that this could happen because the flag we set upon completion... I didn't want to create another GLOBAL setting which would be required in order to survive a reloadUI. I vaguely remember @BreakBB mentioning something about how he was going to fix it so it would survive a reloadUI?
Not trying to lay blame on me or him. :D I just don't want to come in and fix this if it's something @BreakBB was going to already address. I'd be happy to assign this to me and take care of it.
My PR didn’t cover this as it seems. It only hides the marked when completing the quest but they re appear on reload @Dyaxler
This was fixed in one of your earlier PRs, if you remember when you did it and we were testing with extraobjective with text "test". It came back it seems.
I am not sure when exactly I will be able to tackle this. If you have a good idea go ahead @Dyaxler - This shouldn't require a global because even on reload we know if an objective is complete or not.
Hey @Nightmaxman completely different issue. We are working on your issue as well though.
@Cabro So I've circled around back to this issue...
Is it just the tooltips for NPC's that is showing this "extraObjective"? RE: the "Mount up" text...
What about the other icons? Do the spawn/monster icons still exist or did they disappear when you completed the quest?
The regular objective map markers are not re-drawn. It's ONLY the extraobjective ones.
Also, just for clarification, they ALL are removed when you complete the quest. But when you switch chars, or reload, or Hearthstone, literally anything with a loading screen, the extraobjective ones are re-drawn. And only those.
for clarity, are we talking icons on map or tooltips? the topic implies icons.. dyaxlers question says tooltip.. which are we playing with here?
The icons on map/minimap. I know that the mouseover on creature/object tooltips will be handled at a later point.
Fixed in PR: #5013