Questie

Questie

122M Downloads

Deleting a quest item displays the wrong quest in the Static Popup dialogs

Dyaxler opened this issue ยท 1 comments

commented

Bug description

When attempting to destroy an item needed for a quest, we intercept the default Blizzard confirmation popup and add our own specialized message informing the player that this item is for X quest.

This was working when I first wrote it. Must be a recent change that has broken it or it's failing a check somewhere and pulling a quest with zero objectives and displaying that quest title instead.

In the screenshot below it says that the Bottle of Moonshine is for the quest The Defias Brotherhood. It should be for the quest Dry Times. The Defias Brotherhood is a "zero objective" quest. The fact that I think it might have something to do with that is when I attempt to destroy another Item from a different quest it too says The Defias Brotherhood. (2nd screenshot).

Screenshots

image
image

Questie & WoW version

I am uncertain if the source of this bug is in a current release or confined to my own local build based on this PR:
#5043

commented

I was correct, sort of. The last quest log entry (The Defias Brotherhood) was the culprit. It has zero objectives; however, since I'm looping through all quests in the log and since it doesn't trigger a break in the loop, the very last quest name was being used. I've added a local var to save the "current" quest name so when the foundQuestItem is flagged true, that quest title is used instead.