Settings refactoring leftovers
BreakBB opened this issue · 0 comments
General tab
- Enable Instant Quest Text could be moved to Interface Options box below.
-
Maybe add Blizzard quest tracker CVar there too.- Setting this cvar is all kinds of broken, don't touch.
-
Isle of Quel'Danas drop down is empty (on wotlk, not sure if this is expected) - Quest Level Options are mutually exclusive and could be turned into a drop down. All the options there need better descriptions.
- They are technically related to available quest icons on the maps, so should probably be moved to the related settings in the Icons tab.
- Questie Map Button is a bit too bold IMHO.
- Move "Show Quest IDs" option from the Advanced tab there.
- Show Map Coordinates doesn't work on the small new map frame, probably needs same reparenting as the map button.
- Enable Minimap Coordinates text disappears instantly when toggled off, but toggling on only works after the player moves. 🤷 Should be renamed Show instead of Enable to match the other buttons there.
- In Social Options box, move the Disabled option out of the channel drop down and make it a checkbox.
Icons tab
- Move "Show custom quest frame icons" from Icons tab into Interface Options box in the General tab. Everything else in the Icons tab is related to map/minimap icons, so it seems a bit out of place.
- Config Tacking Icons should be replaced with a box like everything else instead of opening the menu frame from the minimap button.
- Replace pfQuest style toggle with something, e.g. opening the style selection window, or remove it.
- Improve description of Hide icons of untracked quests option. Tracked where and how?
- Objective icon cluster amount could use a better description.
- The Icon Colors and Icon Glow options in the Map and Minimap boxes don't use the same colours. This should be changed or they should be made mutually exclusive, because as is they don't interact well.
- Icon Color is per quest, Icon Glow is per objective. Easily changed, but doing it cleanly would take some refactoring.
- The Minimap Icon Fade Distance description is really confusing. It doesn't have a on/off toggle and amount slider like the option for fading icons close to player does.
- Icon Scales box is missing a size slider for talk objective icons.
Tracker tab
- Create sub-groups where it makes sense (e.g. Header and Background options)
- Resize sliders and drop-downs where appropriate
- Review option dependencies (e.g. some options are only available for certain settings in a drop-down, we have no good way to indicate this)
- Review option names and descriptions (e.g. replace "Enable Active Quests Header" with "Enable Questie Tracker Header", remove reference to variables saved per character from "Enable Tracker" description)
Nameplate tab
- This tab seems a bit weirdly named considering it is divided into settings for nameplate icons and for target frame icons.
- Toggling nameplate icons on doesn't draw immediately, toggling off works fine.
DBM HUD tab
- Need to get DBM. 😅
Advanced tab
- Reorder the sections to put things more relevant to the user further up.
Originally posted by @Muehe in #5178 (comment)