Questie

Questie

Addons
122M Downloads

Missing tooltips for quests with multiple finisher

BreakBB opened this issue ยท 0 comments

commented

Bug description

Right now Questie does not register Tooltips for all possible quest finishers. So far it was not required, as every quest had only a specific turn in location/NPC/object.

Places that need changes:

Questie/Database/QuestieDB.lua

Lines 1122 to 1147 in b5d3a5e

---@type FinishedBy
local finishedBy = QO.finishedBy
if finishedBy[1] then
for _, id in pairs(finishedBy[1]) do
if id then
QO.Finisher = {
Type = "monster",
Id = id,
---@type Name @We have to hard-type it here because of the function
Name = QuestieDB.QueryNPCSingle(id, "name")
}
end
end
end
if finishedBy[2] then
for _, id in pairs(finishedBy[2]) do
if id then
QO.Finisher = {
Type = "object",
Id = id,
---@type Name @We have to hard-type it here because of the function
Name = QuestieDB.QueryObjectSingle(id, "name")
}
end
end
end

Questie/Modules/Quest/QuestieQuest.lua

Line 929 in e2097df

function QuestieQuest:AddFinisher(quest)

Quest to test: https://www.wowhead.com/quest=28824/wayward-child

Questie & WoW version