Questie

Questie

130M Downloads

Item 4903 still showing in english

anon1231823 opened this issue · 21 comments

commented

Description

The Eye of the Burning Shadow (item 4903) still shows the tooltip name in english even though the item exists in the esMX database
image

Questie version

v10.10.2

Game flavor

Era/HC/Anniversary

commented

Hey @anon1231823

can you also share examples where the item names are translated correctly? This might be an issue related to the objective times of the quests.

commented

Items in my bags showing correctly: ID 6652, 5062, 2858

Something worth noting: When an item is used for two quests, it can show correctly localized on the first quest, and not localized for the second quest, even if the Item ID is the same

commented

I noticed a lot of items have this same issue

commented

Screenshots would still be helpful!

commented

Sevren's Orders (3017) is another example of an item that exist in the database, but is still showing the name in english
image
image
image

commented

@BreakBB i cannot find those items in the classic lookups, i dont know why he said that they have translations. items 4903, 3017 have no translations

commented

@Cabro https://github.com/Questie/Questie/blob/master/Localization/lookups/Classic/lookupItems/esMX.lua

I see it right there

[3017] = "Órdenes de Sevren",
[4903] = "Ojo de la Sombra ardiente",

commented

You are absolutely right. How did i miss those?

commented

Another example: 3016 and 3081 and 2837 not working. 3082 works though.
image
image
image
image

commented

Hey @anon1231823 a similarity I notice from your screenshots is, that it always bugs out, when the quest is already complete.

Could that be the overall case?

EDIT: Nope, 3082 is working fine 🙈

commented

I went onto the french client to test something from quest 3942. I noticed that when I hovered over the mobs, the samophlange pages and cover show on the tooltip. The items exist in the french database as well as esMX database (11147 and 11148).

[11147] = "Cubierta del manual del churumbele",
[11148] = "Página del manual del churumbele",
[11147] = "Couverture du manuel du Samophlange",
[11148] = "Page du manuel du Samophlange",

image
image
Yet in the esMX client, the tooltip still shows english
image
image
Surprisingly, it does show item 11149 which does exist in the esMX database
image

commented

Is it possible that this has to do with CRLF? I don't know if a document can have partial CRLF and partial LF. When I open notepad (not notepad++) it automatically is CRLF.

commented

Hm, so items with characters such as "á" show in english instead, that's a good spot

commented

Try to save it as LF instead, restart client, let us know if it fixes it

commented

@Cabro Changing to LF seems to have no impact, and some items with special characters are showing correctly
image

commented

It could be when a quest is completed, the object shows the localized name, but not until it's complete
image
image

commented

I just did a dungeon and noticed something. When the item existed in the database, it showed spanish for everyone in group. For the item that didnt exist, it only showed spanish for me. When I left the group, it STILL shows in spanish, even after recompiling database, even though item ID 9299 doesn't exist in esMX item file. So it has some memory of it or got it from the quest objective I don't know what is going on here.
image
image
image

commented

The problem seems to be happening with esMX, I haven't seen it with frFR
image

commented

I remember this item being english, but now with v10.13.0 it shows spanish. I wonder if it is fixed? Will continue to test
image

commented

esMX item translations were not loaded at all since this commit:

494f86d (released with v10.10.2)

But where fixed with this one:

0314319 ( released with v10.12.1)

It would be really great if could continue to keep an eye out 🙏🏻

commented

I haven't seen any instance of an item not showing in spanish unless it didn't exist in the database, so I will consider this as complete and close it. Will re-open if I find anything that is contradictory.