QuickChat

QuickChat

10.1k Downloads

Make buttons take as much space as their text needs

KalitaAlexey opened this issue ยท 26 comments

commented

Most people probably rely on colors instead of labels. For most people 1-2 characters would be enough to distinguish.
Having this as option will make it easier for people.

The following options are suggested:

  • A separate option for each button label
  • Min width = 40

I'll start working on it. Just making sure we don't work on the same.

commented

You are very welcome to work on it. As I already mentioned, I have to update some other addons little by little. Your help is really great. I also had an idea for the settings page. If you have the time, you can open an area for a small text. For example, "please perform a reload after a change." Text for that I would finish the days.

commented

Yeah. I started working on it and the first thing I faced was labels :) I need to read about them.

commented

Take your time. I know how it is when you have big plans but you can't get any further. Have a job and a wife and 2 children. I don't have the time I want

commented

Text for the Settings Page is finish only must make it Translatable.

commented

Yea. I'll continue next week hopefully.

commented

No Problem bro

commented

The settings page looks a little better now:
newsettings

commented

I'm trying to make Slider look like in the Blizzard's UI, but I don't understand how they display text above it. Any ideas? :)

commented

Can you show me an example screenshot. My English is not that good.

commented

image

I have no idea how to do it :)
I think it could be better to just declare min width be 30-40 and let it be.

commented

We would have to look how it looks with the different languages. Don't know if that's enough.

commented

I'm talking about Min Width, but all buttons will also have their width set to fit the label.
Users would need to change buttons' labels if they want them shorter.

commented

ok

commented

image
That's how it looks like when the button's width depends on the text.

commented

Ok and when we now look the width depends on the frame.

commented

Ofc :)

commented

image
Should the frame's padding be increased? (The area to the left and to the right of the buttons. The empty space).

commented

A little becouse moving.

commented

Yes, that was my though :)

commented

image

commented

Ok thats it. Looks fine.

commented

I discussed renaming with my friends and as I thought this feature most likely wouldn't be used.
People rarely want to customize things unless it makes them uneasy.
The reason I'm backing off is that I would have to implement tab or subpages and I don't think it's worth it.
However, they said it would be better if it was just shorter from the beginning.
I could suggest shorter names for buttons in russian or we can keep it as is.
What do you think?

I still think we want to have adaptive buttons though (the behavior on the screenshot above).

commented

I think it is good on your screenshot.

commented

can you send me a pull request with this changes from here?

commented

Sure. I'll do it today.

commented

thx bro