QuickChat

QuickChat

10.1k Downloads

Bug: Buttons are created each time you move your character

KalitaAlexey opened this issue ยท 10 comments

commented

I added print to the function that adds a button and started moving.
At that moment I saw my chat overwhelmed with log message.
It could greatly impact users' experience.

commented

I can't test it at the Moment. I have no play time. Can you send me a screen?

commented

image

I made 2 steps :)

commented

I dont understand why.

commented
function frame:PLAYER_STOPPED_MOVING(arg1)
	if type(QC_Point)=="table" and QC.F~=nil then update_frame_btn(); end
end
function frame:PLAYER_STARTED_MOVING(arg1)
	if type(QC_Point)=="table" and QC.F~=nil then update_frame_btn(); end
end

Dunno :)

commented

Ahhh lol dont have See this. Fuck.

commented

Remove this liens should fix this. Must test it when I have play time end this month.

commented
function frame:PLAYER_STOPPED_MOVING(arg1)
	if type(QC_Point)=="table" and QC.F~=nil then update_frame_btn(); end
end
function frame:PLAYER_STARTED_MOVING(arg1)
	if type(QC_Point)=="table" and QC.F~=nil then update_frame_btn(); end
end

frame:RegisterEvent("PLAYER_STOPPED_MOVING");
frame:RegisterEvent("PLAYER_STARTED_MOVING");

Must delete.

commented

What are CONSOLE_MESSAGE, CRITERIA_UPDATE for?

commented

Must test it when I have play time it's long time ago I have Do this.

commented

I see that CRITERIA_UPDATE also happens when I just run.