Support SoM/ClassicEra

Question

Support SoM/ClassicEra

SabreValkyrn opened this issue 3 years ago · 4 comments

SabreValkyrn commented 3 years ago

Build ability GSheet
Update Build.py for BCC+SoM/ClassicEra
Support multi-toc
Only load expansion-specific ability data

SabreValkyrn · Answer 1 · 2021-12-26T16:14:13.000Z

Foundation added in #22

Gogo1951 · Answer 2 · 2021-12-26T23:07:33.000Z

Nice, I'll get the reviewed data over to you soon!

SabreValkyrn · Answer 3 · 2021-12-27T20:49:53.000Z

#26 should have finished support for SoM.

Will be released with v1.2.0

SabreValkyrn · Answer 4 · 2021-12-28T04:11:49.000Z

So 1.13.0/1 had spellID in combat log, then 1.13.2 removed it. https://wowpedia.fandom.com/wiki/Patch_1.13.2/API_changes

The Combat Log no longer has access to Spell IDs, they are always returned as 0, since they were only added to the combat log in patch 2.4
UNIT_SPELLCAST_* events only fire for the player.

https://wowpedia.fandom.com/wiki/COMBAT_LOG_EVENT

Spell IDs are always 0 on classic_era.

Trimmed functionality for SoM, using https://wowpedia.fandom.com/wiki/UNIT_SPELLCAST_SUCCEEDED #27

Share to