Rarity

Rarity

Addons
17M Downloads

Addon doesn't hide "defeated items"

rdw-software opened this issue ยท 2 comments

commented

WowAce Link

With the latest update the addon doesn't hide "defeated items" even if the option is checked.

This only appears to affect those items added recently, where the defeat detection is missing or broken:

Below are actually tested with the correct Boss name behind it.

Elementium Back Plate > Spine of Deathwing / Greater Cache of the Aspects
Experiment-In-A-Jar > Maloriak
Lesser Circle of Binding > Ascendant Council
Odd Twilight Egg > Theralion and Valiona
Puddle of Black Liquid > Yor'sahj the Unsleeping
Severed Tentacle > Madness of Deathwing / Elementium Fragment
Shadowy Pile of Bones > Nefarian's End
Smoldering Treat > Shannox
Strange Humming Crystal > This item actually drops from a Kirin Tor Chest, Leads to the Quest: Enemies Everywhere which rewards the pet Wondrous Wisdomball.
Twilight Summoning Portal > Cho'gall
Zephyr's Call > Al'Akir
Rough-Hewn Remote > Omnotron Defense System
Breezy Essence > Conclave of Wind
Vibrating Stone > Baleroc
Cinderweb Egg > Beth'tilac
Fandral's Pet Carrier > Majordomo Staghelm

commented

Tested and working:

  • Breezy Essence > Conclave of Wind
  • Cinderweb Egg > Beth'tilac
  • Elementium Back Plate > Spine of Deathwing
  • Experiment-In-A-Jar > Maloriak
  • Fandral's Pet Carrier > Majordomo Staghelm
  • Lesser Circle of Binding > Ascendant Council
  • Puddle of Black Liquid > Yor'sahj the Unsleeping
  • Rough-Hewn Remote > Omnotron Defense System
  • Severed Tentacle > Madness of Deathwing
  • Shadowy Pile of Bones > Nefarian's End
  • Smoldering Treat > Shannox
  • Twilight Summoning Portal > Cho'gall
  • Vibrating Stone > Baleroc
  • Zephyr's Call > Al'Akir

Broken:

  • Odd Twilight Egg > Theralion and Valiona
    This requires an update to the LibBabble-Boss library, as it uses the wrong boss name ("Valiona and Theralion"). A workaround will have to be added - see #22

Won't fix:

  • Strange Humming Crystal > This item actually drops from a Kirin Tor Chest, Leads to the Quest: Enemies Everywhere which rewards the pet Wondrous Wisdomball.

This is probably a copy & paste error, as it's not an item that would require defeat detection.

commented

Fixed in 20d0d74 (and previous commits).