Rarity

Rarity

17M Downloads

Attempts aren't being announced in chat/say

rdw-software opened this issue ยท 6 comments

commented

Source: Curse

i have some iussess with the addon when i do icc heroic 25 mode and the addon doesnt track the lich king mount attempts in chat and i went today after work some blackrock foundry on myhtic and i killed blackhand and the attempt on the mount doesnt also in chat and other mounts also
cant get it to announce attempts after kills in chat or says, as well as its not atking SS at all when items are found

Screenshots not being taken might be a separate issue?

commented

Is this limited to ICC? I can't tell from the comments, but there was this:

the icc mount attempts doesnt show in chat wel the other mounts but not the icc mount

commented

Some Extra Info

One of my Invincible attempts was skipped today, but all my other attempts have worked so far so I've failed to reproduce it. Something weird is happening though...

The encounter seems to be bugged currently. You can now kill The Lich King before the role-play ends, after Tirion charges him and he's floating in the air. At that point the portal to the entrance spawns even if you haven't killed him and you're stuck in combat. The Lich King can still be killed and looted, but combat doesn't end until you leave the instance or force-drop with something like Vanish. Because of this, you can also loot him before ENCOUNTER_END triggers. This may be causing rarity to miss attempts in some cases? When I tried to reproduce it, the attempt was counted from statistics when I left the instance and combat finally dropped.

Loot Before Encounter End, Attempt Found With Vanish
[19:03:04] <DBM> 25 Player (Heroic) - The Lich King engaged. Good luck and have fun! :) 
--
[19:05:15] Highlord Tirion Fordring yells: LIGHT GRANT ME ONE FINAL BLESSING! GIVE ME THE STRENGTH... TO SHATTER THESE BONDS! 
--
[19:05:45] <DBM> 25 Player (Heroic) - The Lich King down after 2 minutes and 39.33 seconds! 
[19:05:45] Rarity: LOOT_READY with target: Creature-0-3138-631-10846-36597-00001A00C2 
[19:05:45] Rarity: Locking session for 1 second(s) to prevent duplicate attempts from being counted 
[19:05:45] Rarity: 6 slot(s) to loot 
[19:05:45] Rarity: Checking NPC guid (1): Creature-0-3138-631-10846-36597-00001A00C2 
[19:05:45] Rarity: NPC ID is one we need: 36597 
[19:05:45] Rarity: Checking NPC guid (2): Creature-0-3138-631-10846-36597-00001A00C2 
[19:05:45] Rarity: Checking NPC guid (3): Creature-0-3138-631-10846-36597-00001A00C2 
[19:05:45] Rarity: Checking NPC guid (4): Creature-0-3138-631-10846-36597-00001A00C2 
[19:05:45] Rarity: Checking NPC guid (5): Creature-0-3138-631-10846-36597-00001A00C2 
[19:05:45] Rarity: Checking NPC guid (6): Creature-0-3138-631-10846-36597-00001A00C2 
[19:05:45] Rarity: LOOT_READY with target: Creature-0-3138-631-10846-36597-00001A00C2 
[19:05:45] Rarity: Session is locked; ignoring this LOOT_READY event 
[19:05:46] Rarity: Unlocking session to continue scanning for new LOOT_READY events 
[19:05:47] Rarity: BAG_UPDATE 
[19:05:47] Rarity: BAG_UPDATE 
[19:05:48] Rarity: Setting lastNode to nil 
[19:05:48] Rarity: Setting lastNode to nil 
[19:05:53] <DBM> DBM has attempted to skip a cut scene automatically. 
[19:05:53] Rarity: ENCOUNTER_END with encounterID = 1106, name = The Lich King, endStatus = 1 
-- Vanish --
[19:06:17] Rarity: Detected UNIT_SPELLCAST_SENT for unit = player, spellID = 1856, castGUID = Cast-3-3138-631-10846-1856-000B9A0779, target = nil 
[19:06:17] Rarity: Statistics indicate a new attempt for Invincible's Reins 
[19:06:17] Rarity: New attempt found for Invincible's Reins 
[19:06:17] Invincible's Reins: 37 attempts 
[19:06:22] Rarity: Scanning instance locks (ATTEMPT DETECTED)
Loot After Encounter End, Attempt Found When Leaving Instance
[17:32:30] <DBM> 25 Player (Heroic) - The Lich King engaged. Good luck and have fun! :) 
--
[17:34:42] Highlord Tirion Fordring yells: LIGHT GRANT ME ONE FINAL BLESSING! GIVE ME THE STRENGTH... TO SHATTER THESE BONDS! 
--
[17:35:13] <DBM> 25 Player (Heroic) - The Lich King down after 2 minutes and 42.19 seconds! 
[17:35:22] <DBM> DBM has attempted to skip a cut scene automatically. 
[17:35:22] Rarity: ENCOUNTER_END with encounterID = 1106, name = The Lich King, endStatus = 1 
[17:35:27] Rarity: Mouse hovered over NPC with id = 36597 
[17:35:28] Rarity: LOOT_READY with target: Creature-0-3138-631-2323-36597-000019EB50 
[17:35:28] Rarity: Locking session for 1 second(s) to prevent duplicate attempts from being counted 
[17:35:28] Rarity: 6 slot(s) to loot 
[17:35:28] Rarity: Checking NPC guid (1): Creature-0-3138-631-2323-36597-000019EB50 
[17:35:28] Rarity: NPC ID is one we need: 36597 
[17:35:28] Rarity: Checking NPC guid (2): Creature-0-3138-631-2323-36597-000019EB50 
[17:35:28] Rarity: Checking NPC guid (3): Creature-0-3138-631-2323-36597-000019EB50 
[17:35:28] Rarity: Checking NPC guid (4): Creature-0-3138-631-2323-36597-000019EB50 
[17:35:28] Rarity: Checking NPC guid (5): Creature-0-3138-631-2323-36597-000019EB50 
[17:35:28] Rarity: Checking NPC guid (6): Creature-0-3138-631-2323-36597-000019EB50 
[17:35:29] Rarity: LOOT_READY with target: Creature-0-3138-631-2323-36597-000019EB50 
[17:35:29] Rarity: Session is locked; ignoring this LOOT_READY event 
[17:35:29] Rarity: Unlocking session to continue scanning for new LOOT_READY events 
[17:35:30] Rarity: BAG_UPDATE 
[17:35:30] Rarity: BAG_UPDATE 
[17:35:31] Rarity: Setting lastNode to nil 
[17:35:31] Rarity: Setting lastNode to nil 
-- LEAVING INSTANCE
[17:38:16] Rarity: Statistics indicate a new attempt for Invincible's Reins 
[17:38:16] Rarity: New attempt found for Invincible's Reins 
[17:38:16] Invincible's Reins: 35 attempts 
[17:38:19] Rarity: Currency updated (CURRENCY_DISPLAY_UPDATE) 
[17:38:19] Loot Specialization set to: Shadow 
[17:38:21] Changed Channel: [1. General - Icecrown] 
[17:38:21] Changed Channel: [3. LocalDefense - Icecrown] 
[17:38:21] Rarity: BAG_UPDATE 
[17:38:21] Rarity: Scanning instance locks (ATTEMPT DETECTED) 

Will update if I learn anything new.

Related Issue?

It may be related to this issue, where it seems WoW isn't even counting attempts for Firelands in the statistics right now. It's possible the Invincible statistics aren't updating in certain situations as well? If that's true, it could be on WoW's end. Tested on a character with no previous attempts.

Firelands Stats

WoWScrnShot_102820_193801
WoWScrnShot_102820_193809

commented

While I'm not sure what's with this issue, I do know the following:

  • The Lich King encounter has had this problem for a long time (years?), and statistics should update as soon as the player drops combat
  • Invincible uses kill statistics, so ENCOUNTER_END should have no effect on tracking attempts for it
  • Firelands statistics are broken, presumably since they introduced the Timewalking difficulty. The same thing happened with Ulduar. See also this issue: #162

I'm not sure why the author of Rarity did this exactly, but it seems statistics are only updated outside of combat. I recall there being a comment about the API calls "timing out" or similar if used in combat, but I haven't followed up to see if this still holds true or if there is a way around it.

commented

Ahh I wasn't aware of the Timewalking issues so thanks for the info! I'll update if I notice any other patterns, but it happens so rarely...

commented

Because of this, you can also loot him before ENCOUNTER_END triggers. This may be causing rarity to miss attempts in some cases?

The fight is super bugged; first time you kill LK on a toon, the fight ends normally. All subsequent kills on that toon, the fight never ends, until you leave the instance.
I've tried, waiting up to 5 minutes after fight, and was still in combat.
I've tried to let the role play, play out (and then wait an additional 30ish seconds) before I killed LK, and still fight didn't end.
It's just horribly bugged..

commented

Indeed, but any attempt counted using the statistics method will still be added as soon as the player leaves combat. Therefore, it shouldn't really be a problem and more of a nuisance :)