Rarity

Rarity

17M Downloads

Add fishing nodes for Shadowlands zones to the addon database

rdw-software opened this issue · 2 comments

commented

From Allara's checklist:

  • Fishing nodes (GatherMate2/Constants.lua)

Do we even need these anymore? I think they might've been used for the Sea Turtle. If not, maybe those from 8.3 and other BFA/Legion content patches might be missing?

commented

Is there even any item fished from pools? Until I learn of any such thing, there's really no point in adding the fishing nodes to the DB, so I'll save myself the work.

commented

Allara:

For a long time, Sea Turtle was added in new expansions, so we needed new fishing nodes for that. They finally stopped doing that, but we still need to add nodes in order to support user-added items. Users get the option to specify Fishing, a Zone, and “Requires Pool.” Requires Pool internally needs you to add all the nodes, otherwise it won’t detect the pools in the new expansion. (It utilizes tooltip scanning.) It can be difficult to remember, but keep in mind that one of Rarity’s strengths is it’s user-added items. And to fully support that stack of features, you have to keep things going like new fishing nodes, LBZ, etc.