Rarity

Rarity

17M Downloads

Some unkill-able Timewalking bosses aren't tracked properly

rdw-software opened this issue ยท 5 comments

commented

CurseForge Link

There seems to be an issue with tracking Timereaver on a couple of MoP bosses in Mogu'shan Palace and Shado-pan Monastery. certain ones that have chests to open at the end of the fight seem to not be tracked properly, so my total kills are now totally inaccurate. There might be one or two in Jade Temple that are also not tracking right.

Relevant: WowAce Ticket

Potential roadmap:

  • Which bosses are missing exactly?
  • Add workaround for those bosses
  • Test the workaround (requires MOP Timewalking event...)
commented

Fixed in d3ba3b5.

commented

I have noticed that the counter goes up twice on some of these encounters. In particular Murozond and Gekkan
I used debugging on Gekkan today to see what caused it to trigger twice.
I believe it's the same issue for Murozond let me know if need to do more debugging for either encounters.

[16:29:09] Rarity: Completed criteria for relevant encounter: Gekkan 
[16:29:09] Rarity: New attempt found for Reins of the Infinite Timereaver 
[16:29:09] Reins of the Infinite Timereaver: 5246 attempts 
[16:29:09] Rarity: Detected UNIT_DIED for relevant NPC with ID = 61243 
[16:29:09] Rarity: New attempt found for Reins of the Infinite Timereaver 
[16:29:09] Reins of the Infinite Timereaver: 5247 attempts ```
commented

Thanks! This looks like a mistake in the encounter detection. It should only track encounters where the boss doesn't die and there's no corpse to loot either. I don't remember if Murozand and Gekkan always worked this way or if something changed (unlikely), so I've removed those two from the detection.

The expected result would be that only one attempt is tracked (for the UNIT_DIED event). Please try the latest alpha (r705-alpha-1), where this should be fixed. Let me know if there are other bosses with duplicate attempts :)

commented

With the change Gekkan now counts only once. Sadly I cannot test Murozond until next Cataclysm timewalking event. Not sure when this double counting started though, but at least it should be fixed now :)

commented

It really depends on whether the boss is actually killable or whether it needs special handling. I guess it'd be possible to do the dungeon normally to check, but then there's no guarantee it would be the same on Timewalking difficulty and I don't have time anyway :D

Currently, the following (non-killable/lootable) encounters should be detected automatically:

  • Ozumat
  • Trial of the King (Mogu'shan Palace)
  • Master Snowdrift
  • Taran Zhu

The list of NPC IDs that should be detected on death may also contain some other encounters working similarly that I'm unaware of. But since there's so many of them, testing them all isn't realistic, so until someone tests them and/or reports one I wouldn't know: https://github.com/SacredDuckwhale/Rarity/blob/7d320ddf25e0fbbec538127170949abdb97f8dd8/Options_Defaults.lua#L1643-L1802