Fishing detection (and spell detection in general) is broken by API changes
rdw-software opened this issue ยท 1 comments
UNIT_SPELLCAST_SENT now has a different signature and works with spellIDs exclusively. The addon tries to detect fishing by scanning for the spell's name, which is no longer possible without using the newly-added Spell APIs.
This may also cause other spell-based tracking to break, such as Opening, Skinning, etc. Needs more investigation!
Roadmap:
- Regular fishing detection: Old Crafty
- Pools / Node fishing detection: Sea Turtle
- Opening spell detection: Wyrmtongue Cache
- Mining spell detection: Elementium Geode
- Herbalism spell detection
- Archaeology
- Disenchant
- Skinning
There are also additional opening spells which use the SPECIAL method (special handling code) and need to be updated to work with the new, spellID-based system:
- Curious Wyrmtongue Cache: Scraps, Pilfered Sweeper
- Crane Nest: Azure Crane Chick
- Timeless Chest: Bonkers
- Snow Mound: Grumpling
- Glimmering Treasure Chest: Toys, Torn Invitation
These remain untested because they're simply irrelevant (for the time being):
- Extract Gas
- Treasures (without text)
Additional tasks:
- Convert detection routines to spell IDs and move away from spell names entirely (if possible)
- Pre-emptively add spellIDs for all expansion gathering skills - they are separated since 8.0.1 - disabled these because I'm not sure how the new split profession system works yet. The IDs are already in the code, though
- Move spell detection to a separate module (file) for readability - will split into separate task later
Fixed in 3b4b73e