Rarity

Rarity

17M Downloads

Refactor SPECIAL handling code and generalize the functionality for future re-use

rdw-software opened this issue ยท 2 comments

commented

Source: Discord

Can anyone point me to an example of how to setup a custom item for a trinket drop from mythic plus dungeons?

This isn't currently possible, but we can refactor the existing SPECIAL detection, which will remove a bunch of duplicated code, to hopefully accomplish this (separate issue as a requirement for this?).

Not sure if M+ dungeons specifically will work with using the exact same logic, should likely review the existing issues pertaining to keystone chest detection.

commented

See also #310 ๐Ÿ˜

commented

I guess this one shall be the refactoring task, then! That is, moving all the not-so SPECIAL handling code and then generalizing it in preparation of the other issue.