Rarity

Rarity

17M Downloads

Collection items aren't counted after having been obtained, even if set to repeatable (?)

rdw-software opened this issue ยท 1 comments

commented

While refactoring the OnBagUpdate event handling code for #373, I noticed that the "total amount" is set to the total number of attempts. Steps to reproduce:

  • Create a custom item (I used a grey one) and add something easily available (I used Netherweave Cloth)
  • Set the amount to 10, so that 10 cloth needs to be collected
  • When collecting the first set of 10, attempts are displayed as expected
  • When obtaining 10 (or more), the achievement popup is triggered as expected
  • Afterwards, the current attempts is below 10 as it was reset, but attempts are not displayed since the total amount is higher

image

I tested this with the current master, i.e. before refactoring as well as with my refactored code, and both times it did not display any attempts.

If this could be reproduced with arbitrary items, especially the collection items added in 9.1, then it will need to be fixed ASAP or tracking won't work on repeat attempts. If there's no point in collecting them multiple times, the priority could be downgraded as most people won't ever experience the bug.

commented

Addendum: After obtaining an amount higher than the last count, the difference will be considered as attempts. This means the previous attempts are discarded or at least not announced.