Pets aren't being marked as "found" when added to the DB after they've already been obtained
rdw-software opened this issue ยท 5 comments
Source: WowAce
Many of the DF items (which were added to Rarity well after I actually obtained them) are still displaying in the summary window... isn't the addon supposed to filter those out? Seems to mainly be happening with battle pets, e.g., Bakar Companion, the various zapthrottle spirits, the Forbidden Reach pets.
According to the code pets should be marked as found in this scenario. Needs testing/confirmation.
Another report in Discord, perhaps something changed with DF? Needs investigating (review API changes).
Also, need to update the section in the FAQ after this has been investigated/fixed (see #254).
The filter flags used in the code are no longer valid:
LE_PET_JOURNAL_FLAG_COLLECTEDLE_PET_JOURNAL_FLAG_FAVORITESLE_PET_JOURNAL_FLAG_NOT_COLLECTED
Instead, there is these two filter flags that Rarity should probably use:
LE_PET_JOURNAL_FILTER_COLLECTEDLE_PET_JOURNAL_FILTER_NOT_COLLECTED
It's unclear what happened to favorites; I don't see any filter for them, so they're probably always visible now?
In theory, it's possible that the filters not resetting causes the problem. But it's difficult to confirm, so I'll leave this open for now.