Rarity

Rarity

Addons
17M Downloads

Class-restricted items erroneously trigger attempts for Dracthyr

rdw-software opened this issue ยท 1 comments

commented

Source: Discord

Toy - Skull of Corruption drop of Gul'dan in Nighthold. Rarity is tracking attempts with Dracthyr. As I understand it the only class this drops for is DH.

This is due to the nature of disableForClass being opt-out. Whenever a new class is added, all items with this setting have to be updated. Thankfully, there's only a few of them in the database, but this would also affect custom items. Maybe there's a way to avoid having to manually update these in the future, which is likely to be forgotten. If not, could at least add some unit tests or other reminders that make sure a mismatch between the list of supported classes and disableForClass settings doesn't survive the CI pipeline.

Affected items:

  • Skull of Corruption
  • Fandral's Seed Pouch
commented

The immediate problem has been fixed via #775. I'll leave this open because future desyncs are still possible without tests.