Rarity

Rarity

18M Downloads

Compare Blizzard's new Base64 encoding APIs with Rarity's built-in implementation

rdw-software opened this issue · 0 comments

commented

In 11.5, Blizzard has introduced APIs to perform Base64 encoding/decoding 1. Rarity has its own Lua version, which is somewhat slow. Note: The speed of encoding/decoding item strings isn't a real concern because most strings are short and it doesn't happen while playing.

Nevertheless, if the implementations are compatible it might be worth considering to let Blizzard handle this task. I don't know if their C API can really handle large volumes of data (and there may be some limits in place), but if nothing else it would be interesting to explore the options.

(The encoding scheme could certainly be made more efficient, but due to backwards compatibility breaking changes aren't feasible, nor needed)

Footnotes

  1. https://warcraft.wiki.gg/wiki/Patch_11.1.5/API_changes