RCLootCouncil

RCLootCouncil

23M Downloads

Cuztomizeable AnnounceItems

evil-morfar opened this issue ยท 4 comments

commented

@SafeteeWoW I made a quick implementation for your suggestion 7ce9f77.

For now, I don't intent to make db.announceItemString editable in game in RCLootCouncil.
It's currently untested, but it should work as intended.

Let me know if that covers your need.

commented

It works. Just need some fixes.

  1. message in line 602 should be msg
  2. We should add an option for this.
commented
  1. 41e07ad
  2. I have nothing to add to it, so I don't see the need for it. Feel free to do so in EPGP though.
commented

I will make a PR for this.
With only &s and &p, there is no need.
But I plan to add "&l": The ivl and "&t": The type(trinket, mail chest, etc), then it will be very useful.

I don't think it makes sense to add this in EPGP.

commented

Handled in #27