RCLootCouncil

RCLootCouncil

27M Downloads

[BUG] Lua error on 3.17.4 (everything breaks pretty much)

mLgz0rn opened this issue ยท 3 comments

commented

Describe the bug
Updated to 3.17.4, and alot of people are having issues in raid.
Loot frame looks like this
Image

Vote frame also seemed broken, and unable to vote, after downgrading to 3.17.3 everything worked fine again.

To Reproduce
Steps to reproduce the behavior:

  1. Update to 3.17.4
  2. Go Raid in Manaforge
  3. When Loot drops and session is started everything errors out
  4. See error

Expected behavior
Everything working :D

Error message

2x RCLootCouncil/core.lua:2753: attempt to index field 'buttons' (a nil value)
[RCLootCouncil/core.lua]:2753: in function 'GetButtons'
[RCLootCouncil/Modules/lootFrame.lua]:387: in function 'UpdateButtons'
[RCLootCouncil/Modules/lootFrame.lua]:309: in function 'Update'
[RCLootCouncil/Modules/lootFrame.lua]:638: in function 'GetNewEntry'
[RCLootCouncil/Modules/lootFrame.lua]:621: in function <RCLootCouncil/Modules/lootFrame.lua:604>
[C]: in function 'GetEntry'
[RCLootCouncil/Modules/lootFrame.lua]:147: in function 'Update'
[RCLootCouncil/Modules/lootFrame.lua]:134: in function 'Show'
[RCLootCouncil/Modules/lootFrame.lua]:93: in function 'Start'
[RCLootCouncil/core.lua]:2985: in function 'OnLootTableReceived'
[RCLootCouncil/core.lua]:2831: in function '_onNext'
[RCLootCouncil/Classes/Lib/RxLua/Observer.lua]:32: in function 'onNext'
[RCLootCouncil/Classes/Lib/RxLua/Subjects/Subject.lua]:57: in function 'next'
[RCLootCouncil/Classes/Services/Comms.lua]:195: in function 'FireCmd'
[RCLootCouncil/Classes/Services/Comms.lua]:183: in function <...faceRCLootCouncil/Classes/Services/Comms.lua:163>
[C]: ?
[LibSharedMedia-3.0-8020003/CallbackHandler-1.0-8/CallbackHandler-1.0.lua]:19: in function <...edia-3.0/CallbackHandler-1.0/CallbackHandler-1.0.lua:15>
[LibSharedMedia-3.0-8020003/CallbackHandler-1.0-8/CallbackHandler-1.0.lua]:54: in function 'Fire'
[BugSack/Libs/AceComm-3.0-14/AceComm-3.0.lua]:260: in function <...faceBugSack/Libs/AceComm-3.0/AceComm-3.0.lua:242>

Saved Variables
I almost always need your saved variables to investigate, so please attach it. It's located at ../World of Warcraft/retail/WTF/Account/"account_name"/SavedVariables/RCLootCouncil.lua.

RCLootCouncil.zip

commented

Thanks for the report. I'm not entirely sure why this wasn't prevented by other code (think you just had unfortunate timing in your reloads) but I've added code that should prevent it from happening.

commented

Thanks for the report. I'm not entirely sure why this wasn't prevented by other code (think you just had unfortunate timing in your reloads) but I've added code that should prevent it from happening.

You mean unlucky as in I reloaded as the loot session started?
A lot of people in the raid had the issue, non of us reloaded as the session was happening.
Even the raid leader had issues :p.
And downgrading instantly fixed the issue.

But thanks for the fix!

commented

Do let me know if you have issues with the latest version, closing this for now