Add a third stat
chadrien opened this issue · 5 comments
Hey 👋
It would be nice to have the option to add a third (or even more?) stat for which to configure caps. My use case is for blood dk where it would be nice to be able to set these 3 stats:
- hit
- at most melee hit cap
- expertise
- at least soft cap
- haste
- at least 1423
- at most 1423
(the at least/most combination being used a workaround to set an exact value).
I took a quick look at the code and saw that it's currently pretty hardcoded to only have 2 stats and didn't manage to quickly get a third working, but with some pointers I could also work on PR if it can help :)
This was one of the first things I looked into when taking over this project and I just don't think I can make it work. The algorithm is just too complex for a single-threaded game like WoW. 2 caps already causes the game to freeze up for my blood dk and just 1 more cap would require optimizations I don't know if I have the time to make and the specs that would even utilize a 3rd cap for this short expansion is maybe 2 or 3.
Also btw, there really isn't an attainable haste cap for any death knight spec. If you're going for haste, get more haste.
How do I get that feature to work? Is it in a Dev branch, or is it not released yet? I would absolutely LOVE to have this functionality, as it would make setting up my dk much, MUCH simpler.