Patch 8.2 taints/errors
reaper666735 opened this issue ยท 5 comments
Hello,
not only hoping for this lovely addon to be updated for 8.2 soon for fixes but also for the new reputations added in it (needed for flying i might add :p)
https://ptr.wowhead.com/faction=2391/rustbolt-resistance#quests
https://www.wowhead.com/faction=2373/the-unshackled#quests (Horde)
https://ptr.wowhead.com/faction=2400/waveblade-ankoan#quests (Alliance)
but i also thought maybe i could give some info from the TaintLog :) :
Global variable _ tainted by RepHelper - Interface\AddOns\RepHelper\RepHelper.lua:2712 DumpReputationChangesToChat()
7/20 19:05:35.499 Interface\AddOns\RepHelper\RepHelper.lua:210 RPH_OnEvent()
7/20 19:05:35.499 RepHelper:OnEvent()
7/20 19:05:35.499 Global variable nextFriendThreshold tainted by RepHelper - Interface\AddOns\RepHelper\RepHelper.lua:2719 DumpReputationChangesToChat()
7/20 19:05:35.499 Interface\AddOns\RepHelper\RepHelper.lua:210 RPH_OnEvent()
7/20 19:05:35.499 RepHelper:OnEvent()
7/20 19:05:35.499 Global variable friendTextLevel tainted by RepHelper - Interface\AddOns\RepHelper\RepHelper.lua:2719 DumpReputationChangesToChat()
7/20 19:05:35.499 Interface\AddOns\RepHelper\RepHelper.lua:210 RPH_OnEvent()
7/20 19:05:35.499 RepHelper:OnEvent()
7/20 19:05:35.499 Global variable _ tainted by RepHelper - Interface\AddOns\RepHelper\RepHelper.lua:2719 DumpReputationChangesToChat()
7/20 19:05:35.499 Interface\AddOns\RepHelper\RepHelper.lua:210 RPH_OnEvent()
7/20 19:05:35.499 RepHelper:OnEvent()
7/20 19:05:35.499 Global variable friendID tainted by RepHelper - Interface\AddOns\RepHelper\RepHelper.lua:2719 DumpReputationChangesToChat()
7/20 19:05:35.499 Interface\AddOns\RepHelper\RepHelper.lua:210 RPH_OnEvent()
7/20 19:05:35.499 RepHelper:OnEvent()
i hope these help :)
i got the email with your question but not seeing it here haha xD,
but anyway yes each time i kill/deliver for rep or just do combat in general i guess, Rephelper might be trying to get info all the time from the reputations ?
Yeah, I was not getting the taint to trigger but stupid me had just forgot to enable the taint log. Fixed those taints except for the _ one since that one is just a throwaway variable.
Will hopefully take a look at the factions tonight.
I have just pushed a release containing the new factions, let me know if I missed something or if I could improve anything. Sorry it took so long.