RepHelper

RepHelper

198k Downloads

Minor Bug

Nanomachiens opened this issue ยท 7 comments

commented

Hey man great addon only one thing i noticed which may be minor to some and major to others. Whenever i complete a quest or just get any rep my tracked Reputation jumps to UC. I don't know exactly why UC but i tried tracking the horde Factions like TB and ORG but whenever i get rep it switches to UC as the tracked one.

commented
commented

I tested it out withput checking any boxes except show all rep gain. Will post screenshot once i get on the server. Will also disable other addons to see if there is maybe a conflict

Edit: The rep i was getting was mostly Org rep, i noticed this while questing in Barrens

commented

I'm getting this as well. Except on the Alliance side, it goes to Stormwind rep.

I also don't see a checkbox to disable show all rep gain. My chat window displays 5 rep gains on some quest turn ins. Main faction listed first, then all 4 alliance factions listed.

I don't have any other rep addons installed. When I disable RepHelper, I get just the one rep message in chat.

image

commented

Oh, now I see what is going on here. It's spillover reputation from quests causing this.

When you get spillover 25% of the reputation gained towards the primary faction also goes to the rest of the main factions (as you can see in the screenshot).

The way that RepHelper prints out reputation changes is by actually checking every faction to see if it has increased or decreased. So in the case of main faction quests that spillover it will print out the changes for all the main factions and switch the reputation bar to the last one that it prints out.

Unfortunately I can't think of a simple fix for that at the moment and it technically works as it should, but it might be something to look into. Any suggestions are appreciated.

https://classic-wow.fandom.com/wiki/Reputation if you want to know more.

commented

Why does the primary faction print twice?

And why does all the spill over print when it doesn't when rephelper is disabled?

Could you just use the highest rep reward to key on the rep bar change?

commented

We just figured out the print twice bug (and how to fix it).

Blizzard original functionality doesn't print the spillover rep (looking at that quest on wowhead also only shows Ironforge, not the spillover).

Your suggested way to fix the bar change is the same solution we came to, that it would be the easiest way to do it. :)

Thanks for the screenshot. It was very helpful.

commented

I have just pushed a update with the fixes mentioned above.

In the next update I will probably make it so that if you disable the option for more detailed chat messages it will revert to Blizzard's default message so that spillover won't be printed at all.

I apparently changed that at some point when updating the addon for Classic and I did not catch it until after pushing this update.