Building my own rotation, I get this error and can't create actions pretty much

Question

Building my own rotation, I get this error and can't create actions pretty much

hsramm opened this issue 7 years ago · 5 comments

hsramm commented 7 years ago

1x RotationBuilder\RotationBuilder-1.71.0.lua:1109: attempt to perform arithmetic on a nil value
RotationBuilder\RotationBuilder-1.71.0.lua:1109: in function `ROB_SpellValidate'
RotationBuilder\RotationBuilder-1.71.0.lua:1675: in function `ROB_Rotation_Edit_UpdateUI'
RotationBuilder\RotationBuilder-1.71.0.lua:921: in function `ROB_ActionListButton_OnClick'
[string "*:OnClick"]:1: in function <[string "*:OnClick"]:1>

Locals:
_spell = "<spell name>"
_spellingCheckPassed = false
_parsedSpellID = nil
_link = nil
(*temporary) = <function> defined =[C]:-1
(*temporary) = ""
(*temporary) = nil
(*temporary) = ""
(*temporary) = ":"
(*temporary) = nil
(*temporary) = "attempt to perform arithmetic on a nil value"
_InvSlots = <table> {
 WristSlot = 9
 BackSlot = 15
 Trinket0Slot = 13
 TabardSlot = 19
 FeetSlot = 8
 NeckSlot = 2
 Finger1Slot = 12
 ChestSlot = 5
 Trinket1Slot = 14
 AmmoSlot = 0
 MainHandSlot = 16
 RangedSlot = 18
 SecondaryHandSlot = 17
 ShirtSlot = 4
 Finger0Slot = 11
 HandsSlot = 10
 LegsSlot = 7
 WaistSlot = 6
 ShoulderSlot = 3
 HeadSlot = 1
}
ROB_EditingRotationTable = <table> {
 bindindex = 0
 SortedActions = <table> {
 }
 ActionList = <table> {
 }
 specID = 1
 isMultiTarget = false
}
ROB_CurrentActionName = "Keg Smash"

hsramm · Answer 1 · 2018-02-14T10:41:25.000Z

Trying to add an Action in my own custom rotation that I am building. Everytime I add an action, I get that error and if it's a brand new rotation and there is nothing there...it won't show an options panel for the action at all.

jdubus · Answer 2 · 2018-02-14T11:28:26.000Z

It seems to me from the error message to be a case of invalid spell. As the spell doesn't exist it isn't valid but there are checks for that, it should normally just say that the spell isn't valid and not bother with it until it is valid. So maybe Blizzard changed something (again) in the way some APÏ functions works in one of the latest patches. It wouldn't be the first time and certainly won't be the last.

vdubus · Answer 3 · 2018-02-14T08:27:14.000Z

Hello, I would like to have a bit more information on how to reproduce this problem.
Could you do the following actions to help us understand this?

Disable all other addon to make sure that's not some kind of conflict.
Clean-up all RotationBuilder.lua file in theses directories: <WoW installation directory>\WTF\Account\<Account name>\Les Clairvoyants\<Each Characters>\SavedVariables.
Uninstall and reinstall Rotation Builder. Check the <WoW Installation Directory>\Interface\AddOns directory to make sure that Rotation Builder was correctly uninstalled.
Try again and describe us how you are producing this bug. Add some screenshots of the rotation you are trying to make to help us understand how the bug occur.

With all these steps, we want to make sure that we will be able to reproduce this bug correctly so we can fix it.

vdubus · Answer 4 · 2018-02-14T21:22:38.000Z

The bug was caused by an update made by Blizzard in their API.
This change broke our usage of the function GetSpellLink.
Check commit 5a2d62e.

Fixed in release 1.72.0.
Currently waiting Curse build for download.

vdubus · Answer 5 · 2018-02-14T20:07:40.000Z

A quick test gave me the same kind of exception.
I will check that.

1x RotationBuilder\RotationBuilder-1.72.0.lua:1109: attempt to perform arithmetic on a nil value
RotationBuilder\RotationBuilder-1.72.0.lua:1109: in function `ROB_SpellValidate'
RotationBuilder\RotationBuilder-1.72.0.lua:1675: in function `ROB_Rotation_Edit_UpdateUI'
RotationBuilder\RotationBuilder-1.72.0.lua:1057: in function `OKCallbackFunction'
RotationBuilder\RotationBuilder-1.72.0.lua:1213: in function <RotationBuilder\RotationBuilder.lua:1211>

Locals:
_spell = "<spell name>"
_spellingCheckPassed = false
_parsedSpellID = nil
_link = nil
(*temporary) = <function> defined =[C]:-1
(*temporary) = ""
(*temporary) = nil
(*temporary) = ""
(*temporary) = ":"
(*temporary) = nil
(*temporary) = "attempt to perform arithmetic on a nil value"
_InvSlots = <table> {
 WristSlot = 9
 BackSlot = 15
 Trinket0Slot = 13
 TabardSlot = 19
 FeetSlot = 8
 NeckSlot = 2
 Finger1Slot = 12
 ChestSlot = 5
 Trinket1Slot = 14
 AmmoSlot = 0
 MainHandSlot = 16
 RangedSlot = 18
 SecondaryHandSlot = 17
 ShirtSlot = 4
 Finger0Slot = 11
 HandsSlot = 10
 LegsSlot = 7
 WaistSlot = 6
 ShoulderSlot = 3
 HeadSlot = 1
}
ROB_EditingRotationTable = <table> {
 ActionList = <table> {
 }
 SortedActions = <table> {
 }
 bindindex = 0
}
ROB_CurrentActionName = "test"

Share to