SavedInstances

SavedInstances

11M Downloads

M+ keys export function across alts

dpyy opened this issue ยท 15 comments

commented

I'm a happy user of SavedInstance for 2 years now, thanks so much for your work.

However, I'm working on an ability to tell my friends what m+ keys I have. Your UI does a great job of showing all my keys between alts but I want an ability to export that. Similar to how simc/WA would do it. A string I can export and paste on a website or another service where I can tell publish the keys that I have.

Every week, me and my friends run into the same situation. Each of us have 4-8 keys each. And every week we play the game of "who has what at what level" game and it's a complete nightmare.

Is this something possible? And if so, any chance we can make it happen? As far as I know there isn't another addon that does this.

commented

That's great news! I think the easiest UI might just be a button next to mythic keystone (one of the rows header in the left) and maybe it can open up a menu to ask for

Announce to guild
announce to party
copy string (where you can come up with a simple text format for outside programs)

commented

I'm in a similar situation and use MythicKeystoneTracker for that specific problem. It can post all your keys (with links) and character names into guild chat, party chat, etc which basically is a good enough solution for me. I guess being able to export a string to post into messengers or other chats would be a nice feature for some people, too.

MKT has its own share of problems, some of which are probably to blame on the Blizzard API. But I don't think it's being actively worked on anymore, so I would be in favor of dropping it if SavedInstances could provide that functionality.

I have some free time on my hands right now (when I'm not doing keys or taking care of my herd of alts), so I could give this a whirl and open a pull request. I guess the basic functionality should be pretty easy, once I figure out where I can find the documentation for the Blizzard API and the additional libs like all that Ace stuff.

What I'm not quite sure about where this would go UI-wise. Like, place a button somewhere on the tooltip/popup? Add some sort of menu to the minimap button?

Suggestions and hints welcome.

commented

So I just did a quick & dirty PoC, which can be found here.

First of all, after looking at the code I found out that you already can click on each character's key and it will insert a link into the chat input window. Not exactly what we want and quite cumbersome for many characters, but maybe a workaround until this gets fully implemented.

Right now it just dumps all your characters and their keys into /say, looking like this:
Anmerkung 2020-06-23 200326

You can trigger this by clicking on the cell in the first column, where the label says "Mythic Keystone". I think that's not the worst place to put this functionality, especially when the subsequent cells on that row have a similar on click functionality.

However, I'm not quite sure where to put the "target selection" part of this. In case you rarely switch this, I guess hiding it somewhere in configuration should be fine. On the other hand, if you basically want to change this on the fly it can be a drag to always go through configuration and hunt down that specific option.

Any of the authors/maintainers have an opinion on this?

commented

This is amazing, I will try this tonight.

I am aware that you can click on each key but it takes a long time when you have 7-8 alts.

Also, can you add an export function to text? The format can literally be as simple as
[Keystone: Kings' Rest (14)], [Keystone: The MOTHERLODDE!! (14)] , ...

This is useful for when we need to parse that from a discord bot or other websites.

commented

I like the idea, would love to define a feature list first though, which exactly did you have in mine in addition what you already mentioned? (Actually would love to get a complete list just for easier discussion)

commented

Some minor improvements:

  • new configuration option for "report target":
    Anmerkung 2020-06-23 232032
    Guild and Party should be fairly self-explanatory

  • confirmation prompts for chat reports:
    Anmerkung 2020-06-23 232033

  • export functionality:
    Anmerkung 2020-06-23 232442

There are still ways to go in improving this, which is why I'd really like some feedback from maintainers here before I open a pull request in your faces.

commented

Let me say this first: reporting to party is basically everything I need, and I only built export because @dpyy requested it initially.

I can see some ways to improve on that small feature set, though:

  • more chat report targets like /w or community channels (basically allow every possible arg combination of SendChatMessage())
    • maybe except /yell
    • this requires an additional text input for targets like whisper or community channels, so keeping the UI in config is maybe not the best place
    • confirmation prompts should be enabled for all of these to prevent (accidental) spamming
  • more control over output
    • filter out realm names
    • omit character names completely, just output flat list of keys?
    • sorting by character name, keystone level, SavedInstances sort order, etc
    • filter out characters?

Off the top of my head, that's all I can think of right now. Maybe someone else has different needs or ideas for related features.

commented

So I did some more touch-ups:

  • if db.Tooltip.ShowServer is unchecked, server names will be filtered out as they would be in other places:
    Anmerkung 2020-07-16 182155

  • added a hover tooltip similar to others to show the current report target:
    Anmerkung 2020-07-16 182511

  • some code reorganization

Even if we don't add any additional features/improvements, there's still work to be done (e.g. i18n). Nonetheless, I would like to get this merged, should I just open a pull request?

commented

Yes please!

commented

Hi, is this feature merged? Can now I export my keys in the latest version of this addon?

commented

Yes, but you need to use alpha since it's not released yet.

commented

but how you active the export ? click on what , do what .

commented

Click "Mythic Keystone" in the main tooltip

commented

When will this be released to production?

commented

Now :)