SavedInstances

SavedInstances

13M Downloads

DF Profession specific tracking

StevesExperiments opened this issue ยท 8 comments

commented

Is your feature request related to a problem? Please describe.
Currently, all of the DF Profession quests are lumped under the weekly quests. While this is sufficient, it requires manually reading through and parsing the text to verify you've done all the profession quests.

Describe the solution you'd like
Ideally, I'd like to see it under it's own subheading instead of lumped in with the ever growing weekly quests. Additionally, I believe it'd be beneficial to be broken out by expansion in case 11.0 continues using professions in this manner.

For example, DF Professions (or something that indicates that this is DF specific). When that is navigated over, it's display a pop up that shows:

Treatise. A check mark should be provided if the character has completed two treatises.

Weekly Quests. A check mark should be provided if 4 quests are completed. (If you're a miner or herbalist, you get one quest instead of two. I'm not sure how to handle this scenario. For example, Alchemy/Enchanting would have 4 quests complete, but a miner/herbalist would only have 2).

Drop Quests. A check mark should be provided if all drop/loot quests are complete. This is more cumbersome because it's profession specific. Miners and Herbalists have 6 while other professions have less.

Describe alternatives you've considered
Writing something to query the WoW API to look at the quests I've completed per character and give me a summary of who hasn't done what.

Additional context
As the profession quests are ongoing, regardless if someone adopts this feature, I will continue to try to add additional quests via PR.

commented

It does. I submitted a PR to SavedInstances to add all those. Currently they're all considered weekly quests.

#668

#653

I'm asking for a way to break those out because trying to filter through 40+ Weekly Quests to determine if I've done the profession stuff is taxing.

commented

https://wago.io/w4D9R3Ykr This WeakAura have lots of IDs

local objectives = {
    {name="Disturbed Dirt or Expedition Scout's Pack (Alchemy)", quests={66373, 66374}, optionKey="alchemy", skillID=171},
    {name="Disturbed Dirt or Expedition Scout's Pack (Blacksmithing)", quests={66381, 66382}, optionKey="blacksmithing", skillID=164},
    {name="Disturbed Dirt or Expedition Scout's Pack (Enchanting)", quests={66377, 66378}, optionKey="enchanting", skillID=333},
    {name="Disturbed Dirt or Expedition Scout's Pack (Engineering)", quests={66379, 66380}, optionKey="engineering", skillID=202},
    {name="Disturbed Dirt or Expedition Scout's Pack (Inscription)", quests={66375, 66376}, optionKey="inscription", skillID=773},
    {name="Disturbed Dirt or Expedition Scout's Pack (Jewelcrafting)", quests={66388, 66389}, optionKey="jewelcrafting", skillID=755},
    {name="Disturbed Dirt or Expedition Scout's Pack (Leatherworking)", quests={66384, 66385}, optionKey="leatherworking", skillID=165},
    {name="Disturbed Dirt or Expedition Scout's Pack (Tailoring)", quests={66386, 66387}, optionKey="tailoring", skillID=197},
    {name="Elementious Splinter - Elemental Enemies (Alchemy)", quests={70511}, optionKey="alchemy", skillID=171},
    {name="Decaying Phlegm - Rousing Decay Enemies (Alchemy)", quests={70504}, optionKey="alchemy", skillID=171},
    {name="Molten Globule - Rousing Fire Enemies (Blacksmithing)", quests={70513}, optionKey="blacksmithing", skillID=164},
    {name="Primeval Earth Fragment - Rousing Earth Enemies (Blacksmithing)", quests={70512}, optionKey="blacksmithing", skillID=164},
    {name="Primalist Charm - Humanoid Primalist Enemies (Enchanting)", quests={70515}, optionKey="enchanting", skillID=333},
    {name="Primordial Aether - Arcane Enemies (Enchanting)", quests={70514}, optionKey="enchanting", skillID=333},
    {name="Infinitely Attachable Pair o' Docks - Dragonkin Enemies (Engineering)", quests={70517}, optionKey="engineering", skillID=202},
    {name="Keeper's Mark - Titan Enemies (Engineering)", quests={70516}, optionKey="engineering", skillID=202},
    {name="Draconic Glamour - Dragonkin Enemies (Inscription)", quests={70519}, optionKey="inscription", skillID=773},
    {name="Curious Djaradin Rune - Djaradin Enemies (Inscription)", quests={70518}, optionKey="inscription", skillID=773},
    {name="Elegantly Engraved Embellishment - Nokhud/Sundered Flame Enemies (Jewelcrafting)", quests={70521}, optionKey="jewelcrafting", skillID=755},
    {name="Incandescent Curio - Elemental Enemies (Jewelcrafting)", quests={70520}, optionKey="jewelcrafting", skillID=755},
    {name="Exceedingly Soft Skin - Slyvern/Vorquin Enemies (Leatherworking)", quests={70523}, optionKey="leatherworking", skillID=165},
    {name="Ossified Hide - Proto-drake or Proto-dragon Enemies (Leatherworking)", quests={70522}, optionKey="leatherworking", skillID=165},
    {name="Ohn'arhan Weave - Nokhud Enemies (Tailoring)", quests={70524}, optionKey="tailoring", skillID=197},
    {name="Stupidly Effective Stitchery - Gnoll Enemies (Tailoring)", quests={70525}, optionKey="tailoring", skillID=197},
    {name="Dreambloom (Herbalism)", quests={71857, 71858, 71859, 71860, 71861, 71864}, optionKey="herbalism", skillID=182},
    {name="Iridescent Ore (Mining)", quests={72160, 72161 ,72162, 72163, 72164, 72165}, optionKey="mining", skillID=186},
    {name="Curious Hide (Skinning)", quests={70381, 70383, 70384, 70385, 70386, 70389}, optionKey="skinning", skillID=393},
    {name="Draconic Treatise (Alchemy)", quests={74108}, optionKey="alchemy", skillID=171},
    {name="Draconic Treatise (Blacksmithing)", quests={74109}, optionKey="blacksmithing", skillID=164},
    {name="Draconic Treatise (Enchanting)", quests={74110}, optionKey="enchanting", skillID=333},
    {name="Draconic Treatise (Engineering)", quests={74111}, optionKey="engineering", skillID=202},
    {name="Draconic Treatise (Herbalism)", quests={74107}, optionKey="herbalism", skillID=182},
    {name="Draconic Treatise (Inscription)", quests={74105}, optionKey="inscription", skillID=773},
    {name="Draconic Treatise (Jewelcrafting)", quests={74112}, optionKey="jewelcrafting", skillID=755},
    {name="Draconic Treatise (Leatherworking)", quests={74113}, optionKey="leatherworking", skillID=165},
    {name="Draconic Treatise (Mining)", quests={74106}, optionKey="mining", skillID=186},
    {name="Draconic Treatise (Skinning)", quests={74114}, optionKey="skinning", skillID=393},
    {name="Draconic Treatise (Tailoring)", quests={74115}, optionKey="tailoring", skillID=197},
}
commented

It does. I submitted a PR to SavedInstances to add all those. Currently they're all considered weekly quests.

#668

#653

I'm asking for a way to break those out because trying to filter through 40+ Weekly Quests to determine if I've done the profession stuff is taxing.

Like the WA I linked, we could get the two prof the player have, list all quest left to do, and show a counter 2/14 with a tooltip with more details

commented

Honestly, that'd be perfect. Unfortunately, I don't know how to work with the UI via lua... yet.

I ended up making my own console app that queries the quest API, but unfortunately, the quest API doesn't consider all quests quests.

commented

I put something together to track this for myself. I'm pretty new to LUA so I am not sure if it's coded the most efficiently, and there are still some enhancements I'd like to add to improve it, but it's at least a start. Not sure the best way to share it, but I guess I could just add the code snippets here in a comment if that would be helpful, or drop in my modified .lua files? I believe my modifications also resolve #402 and #717 (unrelated to Professions, but something else I added).

Is it ok to attach my .lua files to this comment so a contributor could look it over and commit once confirmed it's correct?

Here is how it looks:
image

And the tooltip examples:
Treatise:
image
Quests (I still want to find a way to condense each subtype into a single row, since you can never do more than 1 Trainer or Consortium Quest per week, but I haven't solved the LUA for it yet. Also meant to change the verbiage to "Completed", instead of "Already Looted" for quests that have been finished this week):
image
Lootables:
image

And the updated Character tooltip to solve #402:
image

Also added Timewalking tracking with the correct questIDs for all of the newest weekly quests:
image

commented

I put something together to track this for myself. I'm pretty new to LUA so I am not sure if it's coded the most efficiently, and there are still some enhancements I'd like to add to improve it, but it's at least a start. Not sure the best way to share it, but I guess I could just add the code snippets here in a comment if that would be helpful, or drop in my modified .lua files? I believe my modifications also resolve #402 and #717 (unrelated to Professions, but something else I added).

Is it ok to attach my .lua files to this comment so a contributor could look it over and commit once confirmed it's correct?

Here is how it looks: image

And the tooltip examples: Treatise: image Quests (I still want to find a way to condense each subtype into a single row, since you can never do more than 1 Trainer or Consortium Quest per week, but I haven't solved the LUA for it yet. Also meant to change the verbiage to "Completed", instead of "Already Looted" for quests that have been finished this week): image Lootables: image

And the updated Character tooltip to solve #402: image

Also added Timewalking tracking with the correct questIDs for all of the newest weekly quests: image

Hey there, can you create a pull request for it? Then we can talk it over in there :)

commented

Hey there, can you create a pull request for it? Then we can talk it over in there :)

I added a Pull Request with the two updated files. This is my first time opening a Pull Request, so I hope I did it correctly.

Thanks.

commented

I'm gonna go ahead and second this request. It would be beautiful I could just glance at SavedInstances and know which toons still need to do what profession stuff each week, rather than having to hover each individual toon's weekly quests and then try to make sense of that clustereff.