SavedInstances

SavedInstances

13M Downloads

Tooltip scale broken (Fit to screen as well)

Nillx opened this issue · 23 comments

commented

After the last update my the addon no longer fits on my screen. Clicking "Fit to screen" does nothing but tanks my FPS to 10-15. Tooltip scale does nothing as well, changing it to 0.1 makes the window huge.

image

commented

Still happens even with the latest alpha version which have fixes for this issue (i think)

commented

related to #688 #695

commented

I have the same problem. With the "fit to creen" disabled that screen window with all the characters is loading, but there is no point in this. In another case, it just drops fps to zero and loads forever without displaying the characters.

commented

Sorry for delayed reply. Failing to reproduce the issue in latest alpha (10.0.9-6-gd95f60e) without any addon or with Titan Panel (6.00.12.100005) mentioned in #700. Please provide SavedInstances version, your LDB addon / Minimap icon collector (if any, test without any addon if possible) and SI data file in WTF.

Pings to @Slypknot for reminder.

commented

Edit: After some troubleshooting i found out that its caused by this addon TipTac Reborn. SI works fine when i disable it, not sure what causes this problem.

commented

can confirm that
I disabled the tiptac and the SI works fine

commented
commented

TipTac v23.02.18 has fixed the issue here. With no more info provided, I think Slypknot is encountered the same problem.

commented
commented

Are you missing the SavedInstances.lua or failing to find the path of it? For reminding it's not need to walk though server and character name folder.

commented

Nothing has changed its still lags down the game until disabled I go from 100+ FPS to 4 FPS on just mousing over Thank you Josh Blackledge From: @.> Sent: Saturday, February 18, 2023 10:30 PM To: @.> Cc: @.>; @.> Subject: Re: [SavedInstances/SavedInstances] Tooltip scale broken (Fit to screen as well) (Issue #696) TipTac v23.02.18 has fixed the issue here. With no more info provided, I think Slypknot is encountered the same problem. — Reply to this email directly, view it on GitHub<#696 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A37DI2SOCRUDVX55MW5OT3LWYGOV5ANCNFSM6AAAAAAUS577EU. You are receiving this because you were mentioned.Message ID: @.***>

What is your TipTac version. I tested with TipTac v23.02.18 and SI v10.0.10 and it works good.

commented
commented

It's also working fine for me here

commented

Please provide SavedInstances version, your LDB addon / Minimap icon collector (if any, test without any addon if possible) and SI data file in WTF.

Maybe we need more info about it.

commented
commented

Could you try only enable SavedInstances and TipTac, and share your SI data file? The path to it is WTF/Account/(YOUR ACCOUNT ID)/SavedVariables/SavedInstances.lua.

commented
commented
commented

The problem is still here. I tried enable only SI and TipTac but it did not help. TipTac v23.02.18 and SI v10.0.10

SavedInstances.zip

commented

Repuduced with data file from artazika.

When SavedInstances trying to show tooltip and Fit to Screen is enabled, SI will try to rescale the tooltip if it's too big. Without TipTac, SI will find the correct scale finally and no longer touch the scale. With TipTac involved, TipTac will try to rescale the tooltip too, but fail to reduce it to correct scale but too big. And then SI will try to fix that and cause loop and huge fps drop.

https://github.com/frozn/TipTac/blob/e0a8f3ac930f852f1b0822ac63dd9f821d0062a0/TipTac/ttCore.lua#L1380-L1416

commented

For now, I suggest disable Fit to Screen option and let TipTac control it (but the tooltip will be overflow in some case), or disable :SetScaleToTip function mentioned above, or disable TipTac.

commented

Solved it in TipTac, see here: frozn/TipTac#205 (comment)

commented

Comfirm fixed with TipTac Dev Version.