SavedInstances

SavedInstances

11M Downloads

M+ weekly reward resetting

johnsolver opened this issue ยท 4 comments

commented

For whatever reason blizzard's C_ChallengeMode.IsWeeklyRewardAvailable() only returns true for the very first time you login after a weekly reset on that character.

Afterwards it returns false even if the chest wasn't opened. Perhaps some workaround with saving that state until you open the chest.

commented

Is this still an issue? I haven't seen the reward reset even after relogging.

C_ChallengeMode.IsWeeklyRewardAvailable() always returns valid results, but only if C_ChallengeMode.RequestRewards() has been called before. I don't see this anywhere in the addon, but it seems to work regardless?

commented

It could be that another add-on is calling RequestRewards() ?

commented

Good point, I forgot that the result was most likely permanently stored.

This is an easy fix, then. Self-assigning this while I test the (minor) changes required.

commented

Firstly, thanks for reporting.
I've been giving this problem some thought over the past few days and I agree with your solution, the problem with it is that this will only be picked up if the addon is enabled the first time you log in each week.
I'd prefer a solution that works in all circumstances.
I'll try to find some time to spend on this over the weekend and see if I can figure something out.