SavedInstances

SavedInstances

11M Downloads

Reputation Progress display for DF Renown missing Paragon info

mgarbacz opened this issue ยท 0 comments

commented

Is your feature request related to a problem? Please describe.
In the DF Renown tooltip display, the reputation earned/reputation threshold display shows rather unuseful info if you are into the Paragon levels with the renown. It shows the regular reputation threshold and the amount of rep over the 2500 cap of the renown cap you hit with your rep gain event (i.e. you are renown 29 with Valdrakken and 2499/2500 towards 30 -> use 250 rep token -> this value will be Renown 30 (249/2500) in the tooltip no matter how much more rep you gain). This is a limitation of the Blizzard API.

Describe the solution you'd like
I would expect Paragon info to be combined into the DF Renown reputation display. I have forked this repo, and made the change to solve this as best I could identify to do it within the structure of the code and design of the addon. I will submit a pull request for this change. I hope it is a suitable solution, but I figured this issue could live independent of that solution.

Describe alternatives you've considered
A completely separate display for Paragon info would also work. There is already a display that shows you how many pending Paragon caches you have, but that section doesn't track or show the progress.

Additional context
Here is the df-renown display for a character of mine who is into Paragon with all pre-10.2 DF factions:
renown-display-si

Here is is reputation tab (with the Paragon Reputation addon):
renown-actual-value

SI is displaying data the way that the Blizzard API is reporting it - C_MajorFactions.GetMajorFactionData API doesn't include Paragon info. Running:

/run for i, v in ipairs({2564,2507,2503,2511,2510}) do print(C_MajorFactions.GetMajorFactionData(v)["name"], C_MajorFactions.GetMajorFactionData(v)["renownReputationEarned"]) end

returns:
renown-reputation-earned

Which you can see matches the display from the SI tooltip.

C_Reputation.GetFactionParagonInfo is needed to get the Paragon data:

/run for i, v in ipairs({2507,2511,2564,2503,2510}) do print(C_MajorFactions.GetMajorFactionData(v)["name"], C_Reputation.GetFactionParagonInfo(v)[1]) end

returns:
renown-paragon-api

Which you can see matches the display from the reputation tab with Paragon info (with some modulo applied to the multi-paragon reps).

I would think Blizzard would have been able to simplify this from their end, but who knows how many side effects that would cause.