SavedInstances

SavedInstances

13M Downloads

Savedinstances not showing Classic Timewalking Weekend

Xynas00 opened this issue ยท 10 comments

commented

Is your feature request related to a problem? Please describe.
SavedInstances is not showing the progress/completion of the Classic Timewalking quest/instances in Retail

Describe the solution you'd like
show progress as per all other timewalking

Describe alternatives you've considered
no?

Additional context

commented

Yeah, I've been wondering how to fix this, too, with no success. It's been annoying me all week. :(

I tried yesterday to find out the different Quest ID's involved in Timewalking dungeons, e.g "An Original Path Through Time" (Quest ID 86731) and "The Ancient Scroll" (Quest ID 83285). I could find the ID's for those, but I can't figure out the LFD ID for Classic Timewalking dungeons (so that I could add the line for Classic Timewalking's quest item near the bottom in Modules/Quests.lua, line 654), since the fansites below haven't updated those lists yet (both last updated was 2023). And I can't figure out if such a list has been updated anywhere else.

https://wowpedia.fandom.com/wiki/LfgDungeonID
https://warcraft.wiki.gg/wiki/LfgDungeonID

Completion of both above quests is listed on characters that have done them, under the "Weekly Quests", but there's still no "Timewalking weekly event" row that'd show 0/5 for characters who have only picked up the weekly quest. Or 1/5 in the case for my hunter.

Two days left of this round of Classic Timewalking dungeons (for EU realms), then it'll be until 14th of May that it'll be up again.

commented

Thank you for your work!

On my side, the quest Original Path through Time is not appearing in my weekly quests completed even though i have the timewalking weekend selected in options.

commented

oh by the way, if you click on the [LFGDungeons.db2]( or use this https://wago.tools/db2/LFGDungeons) link on that page you listed and filter the table that appears, i see Random Timewalking Dungeon (Classic) listed with a ID of 2634.
Is that what you were looking for?

commented

i managed to fix it. give me a moment and i will list out what i did

commented

Yeah, I found that as I was writing my reply. I tried to add that to the Modules/Quest.lua, but it didn't seem to help me get it to show current progression.

commented

in Progress.Lua, search for "timewalking" and add this after last entry (should be "A Fel Path Through Time")

  86731, -- An Original Path Through Time - CLA Timewalking

in Quest.Lua, search for timewalking again and add the following to the "weekend event' list

[86731] = "Weekly", -- An Original Path Through Time - CLA Timewalking

in the same file, just below the weekend events, you will find the entry for the item where you will add

[83285] = 2634, -- The Ancient Scroll - CLA Timewalking

Thats all the amendments I did. Appears that the progress is in Progress.lua. The quest file only shows the weekly quests list.

commented

Yep, that fixed it for me. Seems like I missed to find the Timewalking event entry in the Progress.lua file. Windows 10's file explorer's search function suck. It can't find shit, despite I know files that contain certain words in the main folder that I'm searching.

Thank you for the help. :)

commented

Thank you for yours as your post led me to the information i needed. Now how do we get someone to upload the fix lol. Do i leave this open

commented

Yeah, I don't know. I would assume so? Someone who are able to fix the addon, will find this and get it done?

As for others, they now know what files we've edited for ourselves.

commented

so it appears that you can "edit" the code, which will create a proposed change. Then create a pull request, which is a request to the mods to review and integrate the changes.