SavedInstances

SavedInstances

11M Downloads

[Request] tracking for specific items

RM29 opened this issue ยท 7 comments

commented

It would be great if we could add some items to track like Primal Sargerite or Blood of Sargeras by id or names.

commented

Is this really something SavedInstances should do? There are lots of addons tracking inventory. This doesn't seem like it would be related to lockouts or weekly/daily reset-based info at all.

commented

I use an addon called BagSync - Although not updated since Nov'16, it still works perfectly fine, has some useful customization options too. As far as adding this into SavedInstances, although it'd be easy - I fear it would ultimately start cluttering the table going forward.

It already tracks lockouts for transmutes and such for professions, so far that it tracked Farming back in MoP - Whether that code still works, I've no idea. The point I'm trying to make is that SavedInstances has been built for tracking lockouts, M+ keys, chests, currencies at a glance. To dive deeper and figure out which alt has X amount of bloods or sargerite, what alts have what herbs, uncut gems etc yeah that's best using an independent purpose built addon.

commented

Its just that its tracking currencies and so, why ?
Anyway i though this addon was not only doing what it was supposed to do but more.

commented

Actually, looking at what currencies are supported and seeing as bloods and sargerites are a currency - I guess these do actually slot in to what is currently supported. Seeing as you can enable / disable what you track - I personally don't see an issue with this.

Sorry @RM29 - I'd forgotten how many currencies SI supports already. See what anybody else has to say then I'll create a pull request so long as there aren't any objections.

EDIT:
Looked at Bloods of Sargeras and Primal Sargerite and although they're used as a currency, Blizzard haven't implemented them as one. As such, they're items with item ID's rather than currency ID's. Not so sure it can be easily implemented now. It's late, so I'll have a look tomorrow.

commented

I'm not a fan of reinventing the wheel, and so I'll just recommend TradeSkillMaster, Broker_Currency, or similar addons. Bloods are regular items, and their use as a currency is second to them being used as profession/crafting items, or at least that must've been the idea.

@RM29: I don't know for sure why SI tracks currencies at all. Maybe people preferred an all-in-one solution (bad reason to add them, IMHO), or, most likely, they were originally intended to track the weekly limited currencies such as Valor Points - which makes much more sense in the context of past expansions.

@Trid3nt1 : Feel free to create a PR if they can be added similar to existing currencies. If the infrastructure is already in place, the feature creep has already happened so I won't object any further. It's not my place to decide on this, anyway, so I'm just giving my slightly biased opinion.

commented

The compatibility just isn't there to track an item as a currency inside the current code of SI at a glance. I guess this could be another discussion really, streamlining SI and outlining what its actual purpose is?

Legion, what's currently tracked:
Seal of Broken Fate - Bonus Roll
Veiled Argunite - Gear Gambling
Wakening Essence - Legendary Upgrades
Order Resources - Not entirely sure about this 1, but previous Garrison / Shipyard currencies have been tracked so I guess this carries on the tradition.
Brawler's Gold - ?
Nethershard - I guess had its day of being useful to be tracked earlier on in the expac for gear.
Legionfall War Supplies - ?
Curious Coin - ?
Ancient Mana - ? / Although I suppose useful for people using alts to farm Fox mount?

There's even tracking left in the code for currencies removed, such as Writhing Essence (was used to upgrade Legendaries to 970).

It could do with some housekeeping - I personally track Seals, Veiled Argunite, Wakening Essence and Order Resources. Do we really need to have Ancient Mana, Brawlers Gold, Curious Coin and such in SI?

This could also be the time to update what SI tracks as default -

Currency776 = false, -- Warforged Seals
Currency738 = false, -- Lesser Charm of Good Fortune
Currency823 = false,  -- Apexis Crystal
Currency824 = false,  -- Garrison Resources
Currency1101= false,  -- Oil
Currency994 = false, -- Seal of Tempered Fate
Currency1129= false, -- Seal of Inevitable Fate
Currency1155= true,  -- Ancient Mana
Currency1166= true,  -- Timewarped Badge
Currency1191= true,  -- Valor Points
Currency1220= true,  -- Order Resources
Currency1226= false, -- Nethershards
Currency1273= true,  -- Seal of Broken Fate
Currency1149= true,  -- Sightless Eye

Strip it down to Order Resources, if we decide to keep that currency in, and Seals of Broken Fate.

commented

I'm sure there are some people using SI to track currencies, even if it isn't the primary purpose of the addon. Removing established functionality will likely lead to complaints, therefore I'd simply let it be.

As for this issue: If there's no way to track items like BoS/PS currently, I don't know if anybody really has the time to add it. I'll leave it open for now, but I'd say there are more important issues that need fixing even if this wasn't outside the scope of the addon to begin with.