SavedInstances

SavedInstances

13M Downloads

LUA errors in patch 11.1.5

yndara opened this issue ยท 13 comments

commented

Describe the bug
Mousing over SavedInstances on my bar triggers a LUA error

Do you have an error log of what happened?

4x SavedInstances/Core/Core.lua:3829: attempt to concatenate local 'name' (a nil value)
[SavedInstances/Core/Core.lua]:3829: in function 'ShowTooltip'
[SavedInstances/Core/Core.lua]:2597: in function 'OnEnter'
[Bazooka/Bazooka.lua]:1584: in function 'showTip'
[Bazooka/Bazooka.lua]:1389: in function <Bazooka/Bazooka.lua:1380>

To Reproduce

Screenshots

Did you try having SavedInstances as the only enabled addon and everything else (especially something like ElvUI) disabled?
I tried with only SavedInstances and Bazooka turned on. The bug still happened.

Which version of SavedInstances are you using?
11.1.1

Was it working in a previous version? If yes, which was the last good one?
It was working before the patch.

Additional context

commented

As a temporary workaround, if you go into Options->Addons->SavedInstances and under Miscellaneous Tracking uncheck Mythic Keystone it seems to work without issue. There's some bug in the code for getting the name of the Mythic key.

commented

It seems like keystone item link has been changed in Patch 11.1.5. Could you /dump "[Keystone]" (insert keystone to chat by shift+click) and reply the result here?

commented

[10:00:29 PM] Dump: value="[Keystone]"[Keystone: Cinderbrew Meadery (10)]
[10:00:29 PM] Dump: ERROR: [string "return "[Keystone]"|Hkeystone:180653:506:10:160:10:9:0:0..."]:1: '' expected near '|'

commented

Thanks, I put in a PR for this. It seems like there is an extra field in the itemLink that was being split in this patch. I'm not sure what values it had in it before but it doesn't match up.

commented

@hollo6 Perhaps try the change on #962 instead of the one on #961.

Did you include all the changes on #961 including the 2 new variables on top and got this error? The line numbers in your error don't seem to match.

commented

I added your change and now I'm getting spammed with the following LUA error:

11x SavedInstances/Modules/MythicPlus.lua:168: attempt to call global 'C_MythicPlus_GetOwnedKeystoneChallengeMapID' (a nil value)
[SavedInstances/Modules/MythicPlus.lua]:168: in function 'ProcessKey'
[SavedInstances/Modules/MythicPlus.lua]:188: in function 'RefreshMythicKeyInfo'
[SavedInstances/Modules/MythicPlus.lua]:148: in function <SavedInstances/Modules/MythicPlus.lua:136>
[C]: ?

commented

I just commented the 3 lines you deleted and added the 2 new ones after, that's why line numbers didn't match.
Now added your second commit and still getting the same error whenever I loot anything that is not gold or a quest item.
Second commit seems to work from a brief testing.

commented

Hmm! The same error as OP or the one you posted? #962 doesn't include that GetOwnedKeystoneChallengeMapID. I'd reinstall the addon and just use the modified file from https://raw.githubusercontent.com/jonespm/SavedInstances/patch-5/SavedInstances/Modules/MythicPlus.lua

Do you have a Mythic Key in your inventory?

Sorry commented before I saw your edit.

commented

Update 11.1.2 did not fix the issue for me.

Reproduction Steps:
Hover over minimap icons โ†’ triggers LUA error.
Click the icon โ†’ blank frame appears (no information).
Workaround: Disabling M+ keys restores functionality.

Error:

6x SavedInstances/Core/Core.lua:3829: attempt to concatenate local 'name' (a nil value)
[SavedInstances/Core/Core.lua]:3829: in function 'ShowTooltip'
[SavedInstances/Core/Core.lua]:2597: in function 'OnEnter'
[BigWigs/Libs/LibDBIcon-1.0-55/LibDBIcon-1.0.lua]:85: in function <BigWigs/Libs/LibDBIcon-1.0/LibDBIcon-1.0.lua:68>

Image

commented

@mobilty What it might be is if you had logged into alts, you need to reset them as they have the wrong ID in the DB.

Either need to go to Options->Addons->Saved Instances->Characters->Reset Characters
Or login to each of the alts you'd logged into this week.

I should have added this comment to the PR message or but looks like it also is getting fixed to avoid if has a corrupted value in the next release. f6aa36d

commented

@jonespm The login method didn't work, but the reload works, thanks. But now the instance abbreviations don't work, the full name folowed by key level is shown instead. Also the name is colored by key level. The locale is RU-ru.

On screenshot WORK -> DFC -> FLOOD -> PSF

Image

commented

I can't login as servers are down but I think for me it had it abbreviated on en-us. This might be fixed by ba84a21 in the next release as well. I'd file a new issue if it isn't fixed after the next released version. Edit: Looks like just released as 11.1.3.

commented

Unfortunately after the update keys is still coloured names without abbreviations. Tried resetting the character information - no change.