Scrap (Junk Seller)

Scrap (Junk Seller)

21M Downloads

Scrap Cleaner not going by vendor values

chaosblad3 opened this issue ยท 0 comments

commented

Running Software (issues missing this information will be deleted):

  • Addon version: Scrap_Cleaner-8.3.0-1.13.3
  • Server patch: 1.13.7 (38631)

Have you read the changelog? (please don't waste our time)
yes

Describe the bug
In the description for the addon it states that it "Deletes your cheapest Scrap when your bags get full", however this does not appear to be the case, while testing on a fresh character in a starting zone i looted a full inv of items marked as scrap, then sorted the inventory with the highest value (5-7c) at the top and lowest (1-2c) at the bottom, and when I killed another mob which triggered a deletion, it was repeatedly one of the higher value items at the top of the inventory that got deleted instead of the 1-2c items at the bottom.

To Reproduce
Steps to reproduce the behaviour:
Testing method explained in description.

Expected behaviour
It should always delete the absolute lowest vendor value item currently in the inventory, ideally also taking into account stack values, e.g. don't delete a stack of 5 ruined pelts worth 25c if there is a flimsy chain cloak worth 7c that could be deleted instead.

Screenshots
N/A

Error Logs
N/A

Additional context
Indirectly related to the bug, but I do find it slightly annoying that the deletion is triggered on a mob kill with a full inventory and not when actually attempting to loot a corpse that has something worth making space for, as multiple times while testing the above it would delete an item to make space only for me to loot the corpse and it only have some money but no other items to loot or an item that is worth less than the item that got deleted to make room for it.

...and yes I do realize that it probably isn't necessary to min-max which item to delete to such a degree, especially at such low values, but over time and at higher levels those many small instances of sub-optimal deletions adds up to a decent amount of lost spare change!