Scrap (Junk Seller)

Scrap (Junk Seller)

21M Downloads

Desaturation and junk icon are not applied to blizzard junk anymore

xAt0mZ opened this issue ยท 1 comments

commented

Running Software:

  • Addon version: Bagnon_Scrap-10-9.2.7
  • Server patch: 10.1.0.49679

Have you read the changelog?
Yes.

Describe the bug
When Bagnon scrap is enabled, it removes the default junk (currency) icon and doesn't apply the desaturation on the game junk (regardless of the Scrap options)
image

When it is disabled, everything works properly (even tho the icon is not desaturated)
image

This is a regression from previous versions. Either related to the latest releases of Scrap or Bagnon because it was working before the 10.1 releases.

To Reproduce

Install & enable
Bagnon 10.1 for wow 10.1.0
Scrap 10.1 for wow 10.1.0
Bagnon Scrap 10.1-9.2.7

These are the latest versions available on Cursforge atm
Cursforge still pointing to the 9.2.7 zip even if the 10.0.2 version exists.
10.0.2 tested and doesn't work either.

Expected behaviour
The default Blizzard junk should be desaturated and should have the junk icon.

Additional context
Did a bit of debugging. junk is always false for all items, even if I mark junk manually as junk in Scrap.

local junk = Scrap:IsJunk(self.info.id, online and tonumber(self:GetBag()), online and tonumber(self:GetID()))
commented

Closing as not posted in the good repository