Scrap (Junk Seller)

Scrap (Junk Seller)

21M Downloads

Character Specific option not saving

Fiamma29 opened this issue · 4 comments

commented

Which software were you running?

  • Addon version name: Scrap (Junk Seller)
  • Client used: Retail, Scrap version 10.1.8

Have you read the changelog?
Yup

Please describe the bug.
The option "Character Specific" isn't saving, when I attempt to change it a Lua error appears and upon reload the changed option has reverted.

Please describe how to reproduce it.

  1. Speak to Vendor.
  2. Right click Sell Junk button.
  3. Click Options.
  4. Click the + next to Scrap in the left-hand list to expand.
  5. Click Junk List.
  6. Click Character Specific checkbox.
  7. Error appears.

Error Logs are Important!
Message: Interface/AddOns/Scrap/addons/config/options.lua:46: attempt to call method 'SendSignal' (a nil value)
Time: Wed Oct 18 13:14:36 2023
Count: 1
Stack: Interface/AddOns/Scrap/addons/config/options.lua:46: attempt to call method 'SendSignal' (a nil value)
[string "=[tsm error check]"]:1: in main chunk
[string "=(tail call)"]: ?
[string "=[C]"]: in function SendSignal' [string "@Interface/AddOns/Scrap/addons/config/options.lua"]:46: in function method'
[string "@Interface/AddOns/Scrap/libs/Sushi-3.1/classes/core/Callable.lua"]:55: in function `FireCalls'
[string "@Interface/AddOns/Scrap/libs/Sushi-3.1/classes/buttons/Clickable.lua"]:39: in function <...s/Scrap/libs/Sushi-3.1/classes/buttons/Clickable.lua:34>

Locals:

commented

I have exact the same problem.

commented

FWIW, mine seems to be saving, but it's still throwing up the error. I just do a /reload after clearing the error and it starts using the global junk settings.

commented

same problem

commented

Having this error today, thought I'd check for an existing issue before logging a new one. Imagine my surprise when I found my own ticket from a year ago 🤣

This is still an issue, I thought I'd jump into the SavedVariables file to make the change manually while not logged in, but I'm not sure this is possible.

Scrap_Sets = {
["repair"] = true,
["latest"] = {
},
["guild"] = true,
["list"] = {
<loads of item IDs with true/false arguments that I assume is the junk list>
["sell"] = true,
["learn"] = true,
["tutorial"] = 5,
}

Hope we can find a fix soon.