Scrap (Junk Seller)

Scrap (Junk Seller)

21M Downloads

error at login in patch 11.0

Daeveren opened this issue ยท 15 comments

commented

Which software were you running?

  • version 10.2.11

Please describe the bug.
A clear and concise description of what the bug is.

Please describe how to reproduce it.
LUA error at login

Error Logs are Important!
Message: ...AddOns/Scrap/libs/Sushi-3.2/classes/groups/Popup.lua:20: attempt to index field 'Group' (a nil value)
Time: Wed Jul 24 22:08:25 2024
Count: 1
Stack: ...AddOns/Scrap/libs/Sushi-3.2/classes/groups/Popup.lua:20: attempt to index field 'Group' (a nil value)

commented

Aha! Then hopefully it will be fixed soon whenever they find a time to work on that. I briefly looked around the new menu guide, but not sure if I would find a good solution.

commented

1x ...dOns/Scrap/libs/Sushi-3.2-1/classes/buttons/Header.lua:20: attempt to index field 'Clickable' (a nil value)
[string "@Scrap/libs/Sushi-3.2-1/classes/buttons/Header.lua"]:20: in main chunk

Locals:
(*temporary) = nil
(*temporary) = nil
(*temporary) = "Sushi-3.2"
(*temporary) = nil
(*temporary) =

{
}
(*temporary) = "attempt to index field 'Clickable' (a nil value)"

commented

1x Scrap/libs/Sushi-3.2-1/classes/buttons/Red.lua:20: attempt to index field 'TextedClickable' (a nil value)
[string "@Scrap/libs/Sushi-3.2-1/classes/buttons/Red.lua"]:20: in main chunk

Locals:
(*temporary) = nil
(*temporary) = nil
(*temporary) = "Sushi-3.2"
(*temporary) = nil
(*temporary) =

{
}
(*temporary) = 1
(*temporary) = nil
(*temporary) = "attempt to index field 'TextedClickable' (a nil value)"

commented

1x ...crap/libs/Sushi-3.2-1/classes/buttons/ExpandHeader.lua:1: attempt to index field 'Clickable' (a nil value)
[string "@Scrap/libs/Sushi-3.2-1/classes/buttons/ExpandHeader.lua"]:1: in main chunk

Locals:
(*temporary) = nil
(*temporary) = nil
(*temporary) = "Sushi-3.2"
(*temporary) = nil
(*temporary) =

{
}
(*temporary) = 1
(*temporary) = "attempt to index field 'Clickable' (a nil value)"

commented

1x ...dOns/Scrap/libs/Sushi-3.2-1/classes/buttons/Texted.lua:20: attempt to index field 'Clickable' (a nil value)
[string "@Scrap/libs/Sushi-3.2-1/classes/buttons/Texted.lua"]:20: in main chunk

Locals:
(*temporary) = nil
(*temporary) = nil
(*temporary) = "Sushi-3.2"
(*temporary) = nil
(*temporary) = "attempt to index field 'Clickable' (a nil value)"

commented

1x ...s/Scrap/libs/Sushi-3.2-1/classes/buttons/Clickable.lua:20: attempt to index field 'Tipped' (a nil value)
[string "@Scrap/libs/Sushi-3.2-1/classes/buttons/Clickable.lua"]:20: in main chunk

Locals:
(*temporary) = nil
(*temporary) = nil
(*temporary) = "Sushi-3.2"
(*temporary) = nil
(*temporary) = "attempt to index field 'Tipped' (a nil value)"

commented

1x Scrap/libs/Sushi-3.2-1/classes/core/Labeled.lua:20: attempt to index field 'Tipped' (a nil value)
[string "@Scrap/libs/Sushi-3.2-1/classes/core/Labeled.lua"]:20: in main chunk

Locals:
(*temporary) = nil
(*temporary) = nil
(*temporary) = "Sushi-3.2"
(*temporary) = nil
(*temporary) = "attempt to index field 'Tipped' (a nil value)"

commented

1x Scrap/libs/Sushi-3.2-1/classes/core/Tipped.lua:20: attempt to index field 'Callable' (a nil value)
[string "@Scrap/libs/Sushi-3.2-1/classes/core/Tipped.lua"]:20: in main chunk

Locals:
(*temporary) = nil
(*temporary) = nil
(*temporary) = "Sushi-3.2"
(*temporary) = nil
(*temporary) = "attempt to index field 'Callable' (a nil value)"

commented

1x ...ddOns/Scrap/libs/Sushi-3.2-1/classes/core/Callable.lua:20: attempt to index field 'Base' (a nil value)
[string "@Scrap/libs/Sushi-3.2-1/classes/core/Callable.lua"]:20: in main chunk

Locals:
(*temporary) = nil
(*temporary) = nil
(*temporary) = "Sushi-3.2"
(*temporary) = nil
(*temporary) = "attempt to index field 'Base' (a nil value)"

commented

1x Scrap/libs/Poncho-2.0-3/Poncho-2.0.lua:65: attempt to index field 'Types' (a nil value)
[string "@Scrap/libs/Poncho-2.0-3/Poncho-2.0.lua"]:65: in function <Scrap/libs/Poncho-2.0/Poncho-2.0.lua:50>
[string "=(tail call)"]: ?
[string "@Scrap/libs/Sushi-3.2-1/Sushi-3.2.lua"]:23: in main chunk

Locals:
self =

{
__type = "Abstract"
}
kind = nil
name = nil
template = nil
class =
{
__index =
{
}
__super =
{
}
}
(*temporary) = nil
(*temporary) = "Abstract"
(*temporary) = nil
(*temporary) = "attempt to index field 'Types' (a nil value)"
Lib =
{
SuperCall =
{
}
ClassMeta =
{
}
Base =
{
}
}
ClassMeta =
{
}

commented

1x Scrap/libs/Poncho-2.0-3/Poncho-2.0.lua:183: attempt to index a nil value
[string "@Scrap/libs/Poncho-2.0-3/Poncho-2.0.lua"]:183: in main chunk

Locals:
Lib =

{
SuperCall =
{
}
ClassMeta =
{
}
Base =
{
}
}
Base =
{
__type = "Abstract"
}
ClassMeta =
{
}
SuperCall =
{
}
(*temporary) =
{
Abstract =
{
}
Frame =
{
}
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index a nil value"

commented

Hi, this is due to some changes in menu option GUI.

A temporary fix for this is as following:

  1. Go to the addon folder/Scrap/libs/Poncho-2.0
  2. Open Poncho-2.0.lua with a text editor (windows notepad also works)
  3. Go to the very end of the file, you may find "Button = getmetatable(GameMenuButtonContinue).__index,"
  4. Comment this line by put -- in front of it or just delete this line.
  5. Now the addon will work just fine, although the option will be missing.

Since this is a problem in a library that Scrap relies on, so it may take time till the author of the library will fix the issue and distribute in a proper way. Until then, we can fix it in the way above personally.
scrap_error_fix

commented

Since this is a problem in a library that Scrap relies on, so it may take time till the author of the library will fix the issue and distribute in a proper way.

I believe they are made by the same person, @Jailiborc.

commented

Hi, this is due to some changes in menu option GUI.

A temporary fix for this is as following:

  1. Go to the addon folder/Scrap/libs/Poncho-2.0
  2. Open Poncho-2.0.lua with a text editor (windows notepad also works)
  3. Go to the very end of the file, you may find "Button = getmetatable(GameMenuButtonContinue).__index,"
  4. Comment this line by put -- in front of it or just delete this line.
  5. Now the addon will work just fine, although the option will be missing.

Since this is a problem in a library that Scrap relies on, so it may take time till the author of the library will fix the issue and distribute in a proper way. Until then, we can fix it in the way above personally. scrap_error_fix

Thank you for this quick fix...
one observation ... while it gets the addon to work insofar as holding the configuration that was set prior to 11.0.0, there is a remaining error that crops up that seems to be preventing the options panel from showing

1x ...dOns/Scrap/libs/Sushi-3.2-1/classes/groups/Options.lua:45: attempt to call global 'InterfaceOptions_AddCategory' (a nil value)
[string "@Scrap/libs/Sushi-3.2-1/classes/groups/Options.lua"]:45: in function <...dOns/Scrap/libs/Sushi-3.2/classes/groups/Options.lua:33>
[string "=(tail call)"]: ?
[string "@Scrap/addons/config/options.lua"]:8: in main chunk
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "@Scrap/addons/main/main.lua"]:40: in function <Scrap/addons/main/main.lua:40>
[string "=[C]"]: in function `Show'
[string "@Blizzard_UIParentPanelManager/Mainline/UIParentPanelManager.lua"]:487: in function `SetUIPanel'
[string "@Blizzard_UIParentPanelManager/Mainline/UIParentPanelManager.lua"]:294: in function `ShowUIPanel'
[string "@Blizzard_UIParentPanelManager/Mainline/UIParentPanelManager.lua"]:173: in function <...ParentPanelManager/Mainline/UIParentPanelManager.lua:168>
[string "=[C]"]: in function `SetAttribute'
[string "@Blizzard_UIParentPanelManager/Mainline/UIParentPanelManager.lua"]:878: in function `ShowUIPanel'
[string "@Blizzard_Settings_Shared/Blizzard_SettingsPanel.lua"]:377: in function <.../Blizzard_Settings_Shared/Blizzard_SettingsPanel.lua:375>
[string "=(tail call)"]: ?
[string "@Blizzard_GameMenu/Standard/GameMenuFrame.lua"]:68: in function <Blizzard_GameMenu/Standard/GameMenuFrame.lua:65>

Locals:
self = <table> {
 __frames = <table> {
 }
 __count = 1
 __super = <table> {
 }
 __index = <table> {
 }
 __base = <table> {
 }
}
category = "|Tinterface/addons/scrap/art/scrap-small:16:16:2:0|t  Scrap"
subcategory = nil
dock = Frame {
 name = "|Tinterface/addons/scrap/art/scrap-small:16:16:2:0|t  Scrap"
}
group = Frame {
 limit = false
 Footer = FontString {
 }
 name = "|Tinterface/addons/scrap/art/scrap-small:16:16:2:0|t  Scrap"
 title = "|Tinterface/addons/scrap/art/scrap-small:16:16:2:0|t  Scrap"
 Children = <table> {
 }
 calls = <table> {
 }
}
(*temporary) = nil
(*temporary) = Frame {
 name = "|Tinterface/addons/scrap/art/scrap-small:16:16:2:0|t  Scrap"
}
(*temporary) = "attempt to call global 'InterfaceOptions_AddCategory' (a nil value)"
Group = <table> {
 __super = <table> {
 }
 __base = <table> {
 }
 __version = 2
 __type = "Frame"
 __count = 0
 __frames = <table> {
 }
 __index = <table> {
 }
}

I'm not super bothered about it... as my configuration is how I'd like it to be.
but it is worth noting for the author of the addon.

commented

I modified the Scrap\libs\Poncho-2.0\Poncho-2.0.lua like this:

Change the lines (starting at 180)

Lib.Types = Lib.Types or {
      Abstract = {},
      Frame = getmetatable(GameMenuFrame).__index,
      Button = getmetatable(tempContinueButton).__index,
      CheckButton = getmetatable(AddonListForceLoad).__index,
      EditBox = getmetatable(ChatFrame1EditBox).__index,
      GameTooltip = getmetatable(GameTooltip).__index,
}

To this (it'll maintain backwards compatibility):

tempContinueButton = GameMenuButtonContinue
if not tempContinueButton then
    for button in GameMenuFrame.buttonPool:EnumerateActive() do
        -- Locate the "Continue" button.
        if (button:GetText() == _G["CONTINUE"]) then
            tempContinueButton = button
            break
        end
    end
end
if not tempContinueButton then
    Lib.Types = Lib.Types or {
      Abstract = {},
      Frame = getmetatable(GameMenuFrame).__index,
      CheckButton = getmetatable(AddonListForceLoad).__index,
      EditBox = getmetatable(ChatFrame1EditBox).__index,
      GameTooltip = getmetatable(GameTooltip).__index,
    }
else
    Lib.Types = Lib.Types or {
      Abstract = {},
      Frame = getmetatable(GameMenuFrame).__index,
      Button = getmetatable(tempContinueButton).__index,
      CheckButton = getmetatable(AddonListForceLoad).__index,
      EditBox = getmetatable(ChatFrame1EditBox).__index,
      GameTooltip = getmetatable(GameTooltip).__index,
    }
end

Then in Scrap\addons\merchant\visualizer.lua

Change local focus = GetMouseFocus() at line 142 to:

    local focus
    if GetMouseFocus then
        focus = GetMouseFocus()
    else
        focus = GetMouseFoci()[1]
    end

Then in Scrap\libs\Sushi-3.2\classes\groups\Options.lua

Change group.category = InterfaceOptions_AddCategory(dock) at line 45 to:

    if InterfaceOptions_AddCategory then
        group.category = InterfaceOptions_AddCategory(dock)
    else
        local category, layout = Settings.RegisterCanvasLayoutCategory(dock, dock.name);
        Settings.RegisterAddOnCategory(category);
        group.category = category
    end