Missing "link" argument in main.lua (WITH FIX)

Question

Missing "link" argument in main.lua (WITH FIX)

kanegasi opened this issue 2 months ago · 0 comments

kanegasi commented 2 months ago

Which software were you running?

Addon version name: 11.0.8
Client used: Retail

Have you read the changelog?

Yes.

Please describe the bug.

When looting an uncollected gray item, Scrap errors and blanks out all bag spaces past the slot the item is in, including that item slot.

Please describe how to reproduce it.

Loot a gray item with an unknown appearance
(this occurred for me with https://www.wowhead.com/item=220325/pierced-gloves)

FIX:

Scrap/addons/main/main.lua line 155: add "link" to the Search:IsUncollected call

before:
if self.charsets.uncollected or not Search:IsUncollected(id) then
after:
if self.charsets.uncollected or not Search:IsUncollected(id, link) then

Error Logs are Important!

10x bad argument #1 to '?' (Usage: local data = C_TooltipInfo.GetHyperlink(hyperlink [, optionalArg1, optionalArg2, hideVendorPrice]))
[string "=[C]"]: in function `GetHyperlink'
[string "@BagBrother/libs/ItemSearch-1.3-9/API.lua"]:90: in function `IsUncollected'
[string "@Scrap/addons/main/main.lua"]:155: in function `IsFiltered'
[string "@Scrap/addons/main/main.lua"]:72: in function <Scrap/addons/main/main.lua:70>
[string "=(tail call)"]: ?
[string "@Bagnon_Scrap/Bagnon_Scrap.lua"]:43: in function `UpdateBorder'
[string "@BagBrother/core/classes/item.lua"]:127: in function <BagBrother/core/classes/item.lua:122>
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "@BagBrother/libs/Poncho-2.0-4/Poncho-2.0.lua"]:40: in function `Update'
[string "@BagBrother/frames/inventory/item.lua"]:90: in function <BagBrother/frames/inventory/item.lua:89>
[string "=[C]"]: in function `Show'
[string "@BagBrother/core/api/frames.lua"]:32: in function `Show'
[string "@BagBrother/core/api/frames.lua"]:24: in function <BagBrother/core/api/frames.lua:23>
[string "=[C]"]: in function `?'
[string "@BagBrother/core/features/autoDisplay.lua"]:18: in function <...faceBagBrother/core/features/autoDisplay.lua:18>
[string "@BagBrother/core/features/autoDisplay.lua"]:83: in function `ToggleAllBags'
[string "OPENALLBAGS"]:1: in function <[string "OPENALLBAGS"]:1>

Locals:
(*temporary) = "bad argument #1 to '?' (Usage: local data = C_TooltipInfo.GetHyperlink(hyperlink [, optionalArg1, optionalArg2, hideVendorPrice]))"

Share to