
Scrap requires opening the vendor window twice to sell automatically
Closed this issue ยท 5 comments
Is there an existing issue for this?
- I have searched the existing open and closed issues.
Description
Scrap version 11.1.10 doesn't sell junk automatically when the vendor window is opened. Closing the vendor window and opening it again sells the junk items. The problem occurs on all my characters. Reverting back to version 11.1.7 fixed the problem.
Scrap Version
11.1.10
World of Warcraft Flavor
Retail
World of Warcraft Region
US/NA
Tested with only Scrap
I got this issue with only Scrap enabled
Lua Error
Reproduction Steps
- Open vendor window with junk in bags.
- The junk remains in bags.
- Close vendor window and re-open it.
- The junk is sold automatically.
- Uninstall 11.1.10 and install 11.1.7 and problem disappears.
Last Working Version
11.1.7
Screenshots
No response
This is most defiantly a problem with the recent changes to WildAddon-1.1. Which from recent commits, he's been having odd issues, and is trying to fix
He did not answer to any issues here, as far as i can tell. (checked the other issues on the 1st page)
The last closed issue was Feb. 26
There is not a single answere in the tickets here, so i don't know, if he read it at least.
But, at least he keeps updating Scrap (or so ) :D
So after digging through the code and placing print statements everywhere, I think i figured out that this is CallbackHandler
's fault. They have a some recursion protection. Where if I'm understanding it correctly, wont let something register and fire in the same event.
A simple quick fix to find and replace the following line :
Line 40 in 7589a2e
with this block of text:
self:RegisterEvent('MERCHANT_SHOW', function()
C.AddOns.LoadAddOn('Scrap_Merchant');
RunNextFrame(function()
self:SendSignal('MERCHANT_SHOW')
end)
end)
I created a PR for this https://github.com/Jaliborc/Scrap/pull/293/files