Running Software (issues missing this information will be deleted):

• Addon version: 1.13.3
• Server patch: [e.g. Build 8.0.1.27178]
  1.13.3.4.333728
  Have you read the changelog? (please don't waste our time)
  Mark if read.
  READ
  Describe the bug
  When you reload or load into any instance or go through a loading page it equips gray items for no reason.
  To Reproduce
  Steps to reproduce the behavior:

1. Have Scrap Broker Downloaded
2. Have a gray item in inventory
3. Go through any loading screen
4. It will equip the gray instead

Expected behavior
To not equip gray items.
Screenshots
If applicable, add screenshots to help explain your problem.
https://youtu.be/ggtJvqo3Yec
Error Logs
Type /console scriptErrors 1 in the chat and reload the game. If an error window appears, write here the message with ID: 1 (labelled 1/X). This is generally NOT the message that the window shows by default.

Additional context
The video shows the bug happening
THIS IS THE SCRAPER BROKER ADDONS FAULT

Hey, this issue is fixed as of ArkInventory 3.09.36 arkayenro/arkinventory#1359

@chzoney Hey dude, what bag addon are you running? I have the same problem and after doing some testing, I determined it was a conflict with my ArkInventory!

Disabled every addon and started enabling them in clusters to narrow down what the conflict was, with ONLY Scrap and ArkInventory running, I get the same problem with it equipping a grey.

ArkInventory lists Scrap_Merchant as an optional dependencie. Therfore ArkInventory always loads Scrap_Merchant.

You could check at the start of Button:OnMerchant() whether you're actually at a merchant or the function was called for some unintended reason.
if not MerchantFrame:IsShown() then return end

With some very limited testing, I think this conflict has something to do with the auto sell junk option, as I managed to play yesterday zoning in and out of places and logging in and out without it switching to a grey once.

@Urtgard unfortunately I'm unfamiliar with the coding aspect of mods so I've no idea how to do what you're asking :)

@SirNorek Scrap_Merchant is a load on demand part of scrap. It'll load the first time you speak to a merchant and calls the OnMerchant() function which auto sells your junk.

Though ArkInventory lists Scrap_Merchant as an optional dependencie. That means if Scrap_Merchant is installed it will always be loaded at login/reload before ArkInventory.

Them Scrap_Merchant is loaded and tries selling your items. But at login you don't have a merchant window open. If you try to sell items (right click on an item) and the merchant window is closed you don't sell gear, you equip it.

Go to your addons folder and open Scrap/merchant/button.lua
Make a new line right after function Button:OnMerchant() and copy this part if not MerchantFrame:IsShown() then return end
Before doing anything it will be checked whether you can sell stuff or not.

@Urtgard well I tried out your fix, and while it does stop the auto switch bug when I have auto sell turned on, it also seems to break auto sell as it no longer auto sells when opening any vendor with that option on.