SilverDragon - Rare Scanner

SilverDragon - Rare Scanner

20M Downloads

Feature request: customize target frame loot options

addonaddict opened this issue ยท 13 comments

commented

Hello,

Is there a way to remove unusable loot in the target frame?
The behavior i would like from this frame is to only show loot that I still need to get, that is usable by my class (such as plate only transmog for DK's and pets/mounts). No cloth, leather, or mail as you can see from the image below.

If we could customize what we want to see, that would be great.

image

commented

I'm not opposed, but it's a little complicated to get this reliably done with what I have access to in-game. What I could do now, fairly trivially, is make the list contain only loot that's technically "knowable" by your current character, which would be transmog, pets/mounts, and things with associated quests.

The main difficulty is that I'm not sure I can guarantee that the loot shown would actually be loot that'll definitely drop for your current character. For instance, there's things like intellect swords/armor, which you could learn the appearance for if it dropped but which might never drop for you because of how Blizzard has the loot tables set up.

I've previously speculated that I might be able to use the GetItemSpecInfo + GetSpecializationInfo functions to see whether an item is flagged as being appropriate for a spec you're current in... but I'd need to go do research and testing to see whether that actually maps well to how loot tables work.

commented

Thank you for explanation! I am no programmer but perhaps you could "cheat" a little and make it work like a "AllTheThings" addon compatibility thing? Like there would be a check box in your settings to enable this. The rare would take the loot table from ATT addon and output it on your target frame. ATT does a great job at this.
Hope this makes sense

image

commented

I'll note that this is a little bit different from what was requested. It'll give you "loot that can drop", which isn't quite the same thing, because some loot is flagged to drop even when it's inappropriate for your character -- generally this'll either still be transmog gear or will be BoE, though. (Or is just an item that's lacking data returned by this API, in which case I show it.)

commented

You are 100% correct, your recent change fixed a lot of the issues! Thank you SO much. Ive been farming elites for weeks that I didnt need to farm.

commented

One question though - towering exterminator in Korthia - ATT shows possible transmog loot directly from this boss, while silverdragon does not. Any reason for this? Consumption and Kroke have similar loot, but only Towering Exterminator doesnt show this. Looking at it from DK class. Thx.

image
image

commented

Lastly, another weird interaction with "Razkazzar" in The Maw. ATT shows an item still missing, while SilverDragon considers it looted. I checked my transmog collection, it is in fact NOT collected. ATT seems to be right here. Any ideas on the cause?

image

Luckily for me, I managed to get this item right away. ATT was right.
image

Same issue with "Yiva" in the Maw. Making me believe it may be regarding shared appearances. ATT differenciates between different items sharing same appearance. SilverDragon seems to bunch them up into same pile. My suggestion would be to add this as an option for those who want to 100% each elite on the map.

image

commented

As you can see, small things like this make the silverdragon's loot preview unreliable. I want to only look at the neat SilverDragon minimap button to show which rares are left and which are completed, but im forced to pay attention to ATT as well. Hope some improvements here are possible.. thanks again.

commented

Ah, okay. The main issue here is incomplete data in SilverDragon -- both of these are low drop-rate items from 9.1. (Blizzard seeded some stuff onto the original Maw rares then, making them a bit more rewarding than they used to be.) I added what was known at the time, but clearly missed some items as they got discovered.

I'll fix up my dataminer scripts and backfill this stuff.

commented

Wait, I'm wrong and you're right, I do have those. It'll be the shared appearances issue. Since I've got config for how to treat loot now, I can go ahead and add an option to do it at the per-item level rather than the per-appearance level.

commented

That said, there seems to be something going on separately with the cosmetic cloaks -- they're not showing up as appropriate loot when they really should. I will investigate this.

commented

Thank you for such fast response. Glad I could bring light to these things. Looking forward to future updates, let me know if any testing and feedback is needed. :)

commented

Would you mind checking the alpha that's being uploaded now and confirming that it behaves how you expect? There's a new option in the settings for how to treat transmog-completion that you'll need to change, because I left the default behavior the same.

commented

I tested "SilverDragon-v90205.1-2-g90841c3.zip" so far and no issues, working exactly as I was hoping. I will let you know as I use it longer if theres any issues that arise.