Background sound alert not working if blizzard background sound is disabled
solakram opened this issue ยท 4 comments
Current State:
- Silverdragon background sound alert does not play when blizzard background sound is disabled
- Silverdragon background sound alert does play when blizzard background sound is enabled and silverdragon background sound is disabled
Should be:
- Silverdragon background sound alert is played even when blizzard background sound is disabled
- Silverdragon background sound alert is NOT played even when blizzard background sound is enabled and silverdragon background sound is disabled
Tested with all possible settings (Tested with all addons disabled but silverdragon):
| Blizzard Background Sound | Silverdragon Background Sound | Sound alert when in Background | Is expected behavior |
|---|---|---|---|
| Enabled | Enabled | Yes | Yes |
| Disabled | Enabled | No | No |
| Enabled | Disabled | Yes | No |
| Disabled | Disabled | No | Yes |
Since i dont know if it is possible to play background sound when blizzard background sound is disabled (i actually guess not), this may be an unresolvable issue.
Not really, I think. From here I either need to remove the preference for the feature to avoid giving people false hope, adjust the wording to note it probably won't work unless blizzard changes something again, or go digging and see if there's some combination of other cvar-changes that'd make it work again after all.
I do appreciate the level of detail in your report and the testing you did, incidentally.
It does try to do it, via manipulating the Sound_EnableSoundWhenGameIsInBG CVar, and it certainly used to work, but it's possible that client changes since I implemented that have affected it. I'll go prod the code in question and see if there's anything obviously wrong.
Incidentally, are you testing this in Classic or Retail?
On testing this, I think they've changed how WoW handles background sound very slightly, in a way that only really affects people who're pushing the boundaries of the behavior like I am here.
Specifically, WoW used to immediately respond to a change in that CVar regardless of whether it was in the foreground, but now it only changes its background-sound behavior at the moment when the game loses focus. You can see this happening by enabling the "background sound" option in SilverDragon and then tabbing out while the sound is playing -- the game sounds will continue playing in the background
Useful testing snippet to trigger an alert after a few seconds: /script C_Timer.After(2, function() SilverDragon:GetModule("Announce"):Seen("_", 32491, 120, 0.490, 0.362, false, "fake") end)