SilverDragon - Rare Scanner

SilverDragon - Rare Scanner

Addons
20M Downloads

[Cata Classic] Registering non-existent event

Road-block opened this issue ยท 2 comments

commented 
1x AceEvent30Frame:RegisterEvent(): AceEvent30Frame:RegisterEvent(): Attempt to register unknown event "VIGNETTE_MINIMAP_UPDATED"

[string "@SilverDragon/shards.lua"]:11: in function <SilverDragon/shards.lua:7>
[string "=[C]"]: ?

Silverdragon version: v2024.10.1-9-gcd1f26c

commented

One way to fix it other than conditional registering based on client flavor could also just wrap them in validity checks.

From

	self:RegisterEvent("VIGNETTE_MINIMAP_UPDATED")
	self:RegisterEvent("VIGNETTES_UPDATED")

in shards.lua
to

	if C_EventUtils.IsEventValid("VIGNETTE_MINIMAP_UPDATED") then
		self:RegisterEvent("VIGNETTE_MINIMAP_UPDATED")
	end
	if C_EventUtils.IsEventValid("VIGNETTES_UPDATED") then
		self:RegisterEvent("VIGNETTES_UPDATED")
	end
commented

Thanks for pointing that out! Good that this hasn't made it out of the alphas yet, I suppose.