Skillet-Classic

Skillet-Classic

445k Downloads

Process/Pause button

Raulfin opened this issue ยท 12 comments

commented

The Process button text doesn't hide during a milti-item craft after the first item in the set is crafted. No other mods active that, afaik, mess with crafting except mtsl.
WowClassic_bG2FhanBzT

reproduce: craft 2+ of any item, after the first completes the process text will stay on the button.

commented

This should be fixed in Skillet-Classic-1.49-alpha4

commented

the button shows pause during the first craft as expected, but after the first craft it shows process instead of pause during subsequent crafts. seems they just show bacwards after the first craft. clicking it doesn't stop the craft, so it's buttons not just labels, but makes it think it started a new craft and the pause button shows and then works.

during first item;
WowClassic_VApPNSIeUk

during 2nd;
WowClassic_RnzyFVHr7S

commented

still is.

was also wondering if there was somewhere I could request a feature/change.

commented

It seemed like before the button was trying to reset state in the brief moment between the 2 crafts, now it stays static during the whole milti-craft period. Visually this feels better to me.
https://user-images.githubusercontent.com/7994405/191053167-087cd964-27bc-4ece-98da-49866869acbc.mp4

if the clip doesn't work;
https://imgur.com/a/nOUjvPB

commented

was also wondering if there was somewhere I could request a feature/change.

Absolutely! Open an issue! You can put "Enhancement" or "Feature Request" in the title. We'll discuss it and then I'll reject it!

Just kidding... all reasonable requests are considered and implemented when appropriate.

commented

Alright it looks like we have to get serious...
Please type:

/skillet debuglogging on
/skillet tabledump
/skillet debuglevel 4
/skillet tracelog on

With Skillet-Classic closed:
/skillet cleardebuglog
Open Skillet-Classic (it looks like you are using cooking)
Select the test case recipe
Increase count to 3 or 4
Click Queue
Click Process
When processing is complete, Close Skillet-Classic
Logoff or /reload
Zip the character specific saved variables file, Skillet-Classic.lua and post it here.

I'm using First Aid and creating multiple Linen Bandages. When I click Process the button changes to Pause and remains as Pause until the crafting is complete at which time the button changes back to Process. If I click Pause while crafting is in progress, the crafting stops and the queue contains the recipe with an updated count, the button says Process and can be clicked to continue.

Your video clips were semi-useful. The fancy cursor gets in the way and because you have cropped it down so much, the progress bar obscures the button.

commented
commented

Github can be a bit paranoid at times. Use .zip instead of .7z

I think I forgot to add "Update to the latest Skillet-Classic alpha before testing".

It will either be Skillet-Classic-1.49-alpha6 or Skillet-Classic-1.49-alpha7 (a work in progress).

commented

kk just got a6 off curse, 1s

commented

zip file didn't work either, but the button seemed fine now.

https://www.dropbox.com/s/8xfy4vtx0sk7i1x/Skillet-Classic.7z?dl=0

commented

Excellent! Please reopen this issue or start a new one if it fails in the future.