Skillet-Classic

Skillet-Classic

445k Downloads

FPS Drop

Ivokros opened this issue ยท 32 comments

commented

I have frame rate drops whenever I craft anything. Addons works perfectly otherwise it's just a bit hard to use.

commented

You haven't provided enough information for me to do anything about it.

What flavor of WoW? Have you tried with other addons disabled? What does typing /skillet debugstatus display?

Can you capture a video with an on-screen FPS display? Pick something simple like linen bandages or a low-level cooking recipe.

If there is a problem with Skillet-Classic, I will need a reproduceable case to debug with. I may also need the specs on your machine.

commented

I have been experiencing the same issue. I will note the issue is more noticeable with multi ingredient recipes. When crafting bandages the framedrop is not as noticeable. So i do believe its happening in the addon updating the substraction of the mats and the addition of the crafted it. Averaging what looks to be around a 40fps drop on the crafts. FPS meter is at the top right of my chat window. I reset my graphics setting prior to recording to see if that would help so my ui is no longer scaled correctly.

I moved my druid to a random location staring at a mountain so we wouldnt have people running by. I also left some time at the end just standing there hovering around 200 fps with the skillet window closed.

https://youtu.be/t7kh1KOTEO4

Currently playing on the Nightslayer Realm on the Classic Anniversary edition.
At the time of recording:
Addon version: 2.09

Other enabled addons:
Auctionator
Prat
Bagonator
MoveAny

System Specs
Ryzen 7 2700
32gb Ram
Nvidia GeForce RTX 3060 12GB DDR5

commented

Thank you for the details. The video is marked as private.

If I turn off Vertical Sync, I can see an FPS drop when crafting Linen Bandages. On my new system with an Intel Core Ultra 9 285K and a NVIDIA GeForce RTX 4070 Ti SUPER I go from 590 FPS to 400 FPS. In the heart of Orgrimmar at the Auction House, my FPS drops to 300 FPS just standing there.

All those FPS values (and your 200 FPS) are, IMO, overkill. Yes, Skillet-Classic will use more resources to update the frame but the alternative of not updating the frame while crafting will (and have) generate(d) many more complaints.

I still have my old system and I have a monitor that has more than a 60 Hz refresh rate, so I'll do some experiments but, at the moment, I don't see this as an issue that needs fixing.

commented

Sorry for not providing more details.
I play on classic era. I use lot of addons but I have attempted disabling them all except skillet and the issue persists. The FPS drop occurs when I finish crafting the item. It's a brief freeze after each craft completes. The FPS is greater when I have more addons running.
I have an RTX 3060, an SSD and 32g of ram and wow normally runs with no fps issues.
Debugstatus shows this
[03:39] WarnShow= nil, WarnLog= true
[03:39] DebugShow= nil, DebugLogging= nil, DebugLevel= nil
[03:39] TraceShow= nil, TraceLog= nil, TraceLog2= nil
[03:39] ProfileShow= nil
[03:39] TableDump= nil
[03:39] LogLevel= nil
[03:39] #DebugLog= 4000 (4000)
[03:39] #DebugProfile= 0 (2000)

commented

Intel i7-10700 CPU @ 2.9GHZ/
FPS normal in SW about 130. Next reading I see after the stutter is 90 but I assume since my screen freezes that is not accurate. Vsync disabled.
The file I have by that name is a .toc file. Should I upload that?
BTW this addon is awesome I wouldn't ask for your help with this if it wasn't. Thanks!

commented

What CPU do you have? Can you tell me what your FPS is normally and the magnitude of the FPS drop? Are you running with Vertical Sync disabled?

I'm a little concerned about the "full" DebugLog with nothing but WarnLog enabled. Please zip your character specific saved variables file, Skillet-Classic.lua, and upload it here.

You can type /skillet debugoff, /skillet cleardebuglog, and see if that helps.

As you can see from my previous post, I also see an FPS drop when crafting but while 590 to 400 is a big drop, at those FPS levels, it's not causing any significant issues for me (and I normally run with Vertical Sync so there is no noticable FPS drop). Can you elaborate "bit hard to use"?

commented

Skillet-Classic saves data from session to session in two locations, the global saved variables file in ...\World of Warcraft\_classic_\WTF\Account\BSMORGAN\SavedVariables and the per character saved variables file in D:\World of Warcraft\_classic_\WTF\Account\BSMORGAN\Mankrik\Naturos\SavedVariables. Substitute your account name, your realm name, and your character name for mine. Both filenames are Skillet-Classic.lua. GitHub won't allow .lua file uploads so you must zip them first and if I ask for both files, then rename the character specific file to include the character name.

If you turn on Vertical Sync, does the stutter go away? Can you capture a video of the process that shows the stutter? Ideally, craft something simple like linen bandages and do so in a quiet place outside of StormWind (one of my favorites is inside an instance). As I said above, I need a reproduceable case and will need to craft many things multiple times.