Skillet-Classic

Skillet-Classic

445k Downloads

Feature Request: Ping WoW in the Taskbar on Queue Step Completed

Closed this issue ยท 6 comments

commented

Similar to the current "Sound on Empty Queue" option, except that it triggers when the current craft step finishes, and it pings/highlights WoW even if it's alt-tabbed in the background.

Thank you for your work, and my apologies if this is in the wrong form/location.

commented

Extract Skillet-Classic.zip into your ...\Interface\Addons\Skillet-Classic folder. The new option is right below the sound on empty queue option. I'll have to do a build to get the name and description updated.

If you don't like that sound, go to https://www.wowhead.com/sounds, find something you prefer, and let me know.

commented

Thank you, that was fast!
And great choice of sound :)
I think I mixed the pinging the taskbar in with the sound playing also when a queue step finishes. I found out this can be done with the lua call FlashClientIcon(), I've added this locally, seems to work. You might consider adding a third option for also flashing the taskbar on a queue sound, but I'm happy in any case!
Thank you very much!

commented

Show me your code (a few lines on either side) and I'll investigate it.

commented

My other issue was simply that I am usually alt-tabbed and the sound doesn't play while WoW doesn't have focus.
I'm not a coder, All I did was add it where you trigger the sounds:
if self.db.profile.sound_on_empty_queue and qsize == 0 then
PlaySoundFile("Sound/Creature/Peon/PeonBuildingComplete1.ogg", "Master")
FlashClientIcon()
end
if self.db.profile.sound_on_remove_queue and qsize ~= 0 then
PlaySoundFile("Sound/Creature/Peon/PeonYes3.ogg", "Master")
FlashClientIcon()
end
The sound still doesn't play while WoW isn't active, but I get notified, like when a Tell arrives or a BG pops.

While WoW is in focus, the sound plays as usual and nothing else happens as far as I can tell.

commented

Skillet-Classic-2.13-alpha1 contains localized options for both sounds and flashes. Note that flashes only work if the corresponding sound is also enabled. Let me know if you think they should be separated.

commented

Thank you very much!

This perfectly serves me, with the sounds and flashes enabled I get notified when it's done crafting in the background.
Until someone comes along that really hates the sounds but does want the taskbar flashes, I don't think it needs to be separated.
In fact, I don't think it ever needed to be separated this much... Though I think granular settings is great, the people uninterested don't need to look at it...

But please don't let me complicate your project further, it works great, thank you for your efforts!