Skillet-Classic

Skillet-Classic

445k Downloads

[MoP Classic] Some features requested

Domekologe opened this issue · 7 comments

commented

Hey,

at first. Nice mod, it helps me a lot.
Is it possible to add maybe some of new features?

Profession: Enchanting

  • Creation of Materials only have 1 Button instead of a queue (There is no restriction from Blizz Side to create a queue)
    • Only for Enchants itself it must be once :D

Profession: All

  • The Search/Filter isn't working completely
    • When I enter a Stat in a profession which create Gear (like Tailoring) I didn't get any result (there should be a function which reads the tooltips of the Item)
    • Also is it possible to enter multiple which is separated by space? (like: int crit) would be for Jewelcrafting much easier to find the correct gems (there are too much)
commented

there should be a function which reads the tooltips of the Item

There is a function, it is called in the Skillet-Classic code, and it works on Classic Era but it doesn't work on Classic MoP. I've been wracking my brain to figure out why because I can display (and add to) the tooltip in other parts of the code. Hopefully, I'll find a solution.

enter multiple which is separated by space

This is exactly how it works on Classic Era (and MoP if the two words are in the search text that does get collected).

Profession: Enchanting

Let's discuss this in #214.

commented

This is exactly how it works on Classic Era (and MoP if the two words are in the search text that does get collected).

Ok maybe I must use the exact german wording (I use german UI and we like it to mix it :D)

commented

At the moment, it doesn't matter what wording you use because the function that is supposed to return the contents of the tooltip isn't working for me on Classic MoP. Lines 284-285 in ...\Addons\Skillet-Classic\UI\Sorting.lua (tiplines is always 0).

The contents of the Search text box is passed to string. Lower and is then split into words with string.split using space as the separator. For each word in the list, the search string (which is supposed to contain the tooltip text) is searched with string.find. Lines 236-323 in ...\Addons\Skillet-Classic\UI\Sorting.lua

This search results in an "or" of the word list. Currently, there is no "and". If the first character of the search is "!", then only the recipe name is searched.

commented

Skillet-Classic-2.18-alpha1 has code to address this issue.

It wasn't working for me yesterday but is working for me today. Let me know how it works for you.

commented

Skillet-Classic-2.18-alpha2 adds '+' as a separator in the Search text to 'and' the words.

For example, in Tailoring the string "fire resistance" results in finding all recipes with resistance but "fire+resistance" will only find recipes with Fire Resistance.

Note: You can't mix separators. Either use " " or use "+". You can still use "!" as the first character for force using just the recipe name in the search.

commented

As you mentioned, this not works really
It gives me completely funny results now :D

Image This is only "krit" (which means crit, but also crit give the same) Image This is only "int" Image This is "int " (with the space) Image

This is "int krit" ("int crit" give the same results). this item only have Int :D

commented

What I have discovered is that some of my characters work and others do not. I haven't discovered yet why that is.

The next alpha will store the tooltip information in the global saved variables file so you can share yours with me if needed.

This is "int krit" ("int crit" give the same results). this item only have Int 🗡️

Remember that words separated by a space are "or". With your example, "int krit" will find any that have int or krit. To find both on the same recipe you would need to use "int+krit".

I'll let you know when I release the next alpha. I'm still working on it.