Skillet-Classic

Skillet-Classic

445k Downloads

Recipe transmute: Earthstorm Diamond doesn't work when all recipes are discovered

xCharg opened this issue ยท 5 comments

commented

So I don't have any mats in my bag (although I do have everything but primal earth in bank, if that matters, and bank is not open during testing). When I press on queue or create on this recipe - game hangs for like half a second and then nothing happens.

I've enabled /skillet debugshow and this is the result: https://i.imgur.com/9C6U6Ae.jpeg

I'd guess that addon tries to recursively transmute life to earth and earth to live and then crashes at some point.

Proposed solution - remove transmute primal into primal recipes from possible prereqs from transmute: earthstorm diamond and transmute: skyfire diamond as that's almost never a good option. Or add enabled by default option that does that.

commented

You are correct in your assessment of the problem. You can fix this yourself by right-clicking the transmute primal into primal recipes and clicking Ignore, Add Recipe to Ignored List.

There is already a table, TradeSkillIgnoredMats, defined in SkilletData.lua lines 196-249 that is supposed to prevent this from happening. This table is used in SkilletQueue.lua at line 98. Unfortunately, I don't have a character with enough skill in Alchemy to test but this table may not have the right data for Classic.

Since you enabled debugging, I need you to upload two files. First, your global saved variables file, Skillet-Classic.lua and second, the character specific saved variables file Skillet-Classic.lua. Github doesn't allow .lua files to be uploaded the easiest solution is to zip the files and upload that instead. Rename the character specific file if you put both in the same .zip. You don't need to capture the chat log to upload

Skillet-Classic debugging goes to two places, the chat log and to the character specific saved variable file which is only written when you logout (or type /reload). /skillet debugshow is a toggle for the chat log but the saved variable logging turned on but not turned off.

commented

Thanks I'll try ignore function. I actually had no clue what it does, my initial guess was that it removes recipe from list but it didn't.

As for files, I've looked through them both and they do not seem to have any info about that error, as I've disabled debugging after taking screenshot. So am I right that I'd have to reproduce issue with debugging turned on, and then /reload for data to be written into file, and then send them?

commented

/skillet debugstatus will show the current debug settings. /skillet debuglogging controls the saving of debug output to the saved variables file. Unless you figured that out, logging should still be enabled so you would just recreate the problem, /reload or logoff to write the file, and then upload it.

But instead of building your own Ignored List (which are recipes that are not recursed), try Skillet-Classic-1.38-alpha1 instead. The table contained the wrong information and this version should fix it.

commented

Turned out that issue only occured when I didn't have primal earth in bank or inventory, so I had to mail these to my alt to reproduce. Here are the files SavedVariables.zip

1.38 alpha1 did indeed fixed this issue too.

commented

Thanks for testing.