Skillet-Classic

Skillet-Classic

445k Downloads

tbc enchanting voidsphere atr buyout not read, so incorrect profit percentage

chorp-cpu opened this issue ยท 5 comments

commented

tbc skillet v 1.42
enchanting voidsphere shows no atr buyout, so the profit percentage is just minus the cost. auctionator does have data data for the voidsphere and mousing over one in the bags shows an auction value.

commented

I'm not sure I understand the issue. Skillet-Classic interfaces with Auctionator (ATR) through its published API. If that API isn't providing the correct data, there is nothing Skillet-Classic can do about it.

Furthermore, the data that Auctionator does supply is collected by scanning the AH making it unique to each account.

If you think the Skillet-Classic Auctionator plugin should be doing something different, please provide enough detail so I figure out what should be done.

commented

I dont know how to make it clearer.

for voidsphere under enchanting:
ATR Buyout: 0c
cost: 21g80s0c
Profit: -21g80s0c
Profit percentage: -100%

yet when i mouse over a voidsphere in bags i get:
auction 44g70s0c

obviously auctionator has voidsphere auction price in its database, but skillet cannot read it and its reporting 0.

skillet should be saying
ATR Buyout: 44g70s0c
cost: 21g80s0c
Profit: 22g9s0c
Profit percentage: 195%

commented

I don't have an enchanter with high enough skill.

According to Wowhead, a Void Sphere is item 22459 and
/dump Auctionator.API.v1.GetAuctionPriceByItemID("Skillet-Classic", 22459) on my server returns 394000 (39g40s0c). What does it return on yours?

Try adding an additional line to ...\Addons\Skillet-Classic\SkilletData.lua after line 288 so the end of the table looks like:

	[28019] = 22522 , -- Superior Wizard Oil
	[28028] = 22459 , -- Void Sphere
commented

/dump returns:
[1]=489000
that lua edit fixed it.
atr buyout 48g
cost 19g
profit 28g
percentage 144%

commented

Thanks, I'll add that line in the next build.