Skillet-Classic

Skillet-Classic

445k Downloads

Skillet no longer showing craftable counts unless all components are already in my bags

red13dotnet opened this issue ยท 11 comments

commented

Skillet is no longer showing craftable counts unless all components are already in my bags.
Attached screenshot showing counts for components in bank are sufficient to produce but count is not reflected on the recipe list pane.
All filter options are set to ON.

Have already attempted savedvariable reset and this screenshot was taken with no other addons loaded
skillet_bug
.

commented

We will probably need to enable debugging to get to the bottom of this but first, copy the global saved variables file Skillet-Classic.lua and the four per character saved variables files renaming each one from Skillet-Classic.lua to .lua, zip them and attach here. I'll take a look at them and then post instructions on enabling debugging if we need to go that route.

commented

Double checked and it actually does seem to be affecting all 4 characters.
Requested files attached
skillet_classic_issue_77.zip

commented

You say "Skillet is no longer" and I need to ask, when did Skillet-Classic ever work this way? Retail WoW (i.e. Skillet) allows crafting using items in the bank, Classic WoW doesn't.

commented

Yeah, i think you hit the nail on the head. I really could have sworn you could queue up items from counts based on bag and bank contents and then use that to pull the items out of your bank when you visited the bank. I must have misremebered after starting classic again. Sorry for the trouble.

commented

I think the best Skillet-Classic could do would be to add an option similar to "Use guildbank as another alt", i.e. "Use bank as another alt". I think I have this working. Do you want to try it?

BTW, If you queue an item you don't have the mats in your inventory but you do in your bank, Skillet-Classic will pull them from the bank when you open it (if configured to do so).

commented

I would love to try it, thank you!

commented

Skillet-Classic-1.47-alpha2 has a new option to use the character's bank as another alt. Note that all reagents must be available in the bank, i.e. You can't have some in inventory and some in the bank.

Let me know if this is useful or if you find any bugs. Also note that this is the code that should run on Wrath pre-release and Wrath (minus the .toc changes).

commented

I will give this a try and let you know.

Thanks again!

commented

That build is certainly way closer to what I was thinking and I havent noticed any errors so far.

I do want to verify this is expected behavior:
Craftable counts for bank contents do not reflect craftable reagents whose components are in the bank.
Example: Tailoring Linen Bag, If I have a stack of linen in my bank, then the bank(alt) number of craftable bags remains zero but the craftable bank(alt) number for crafting bolts of linen cloth is correct.
If that same stack of linen is moved to inventory, the craftable by crafting reagents reflects the correct number.
However if I then turned the linen into bolts, and put those bolts in my bank, then the craftable bank(alt) count is correct.

commented

I believe your example is correct. I didn't change the calculation of the craftable count. The alts count only checks for the actual reagents. It does not consider reagents that could be used to craft the reagent needed.

The "magic" happens when you queue, for example, a Linen Bag when you don't have all the materials in your inventory. The shopping list is now populated with any missing reagents including the reagents required to craft reagents. When you visit your bank it can pull what it needs into your inventory. When you visit merchants that sell needed reagents, Skillet-Classic will buy them for you, and if you switch to alts that have reagents in their bank (or inventory), you can use the command "/skillet shoppinglist" to see what is needed (and who needs it).

There are many addons that will collect information about the contents of your alt's bags and banks and add that information to the tooltips that Skillet-Classic displays. Skillet-Classic knows some your alt's inventory but only if you've used Skillet-Classic on that toon. I use Altoholic and tooltips from the shopping list to see who has what.

commented

Thank you, I think this will work just fine.
I appreciate the work you've done.