Dragonflight 10.x compatibility

Question

Dragonflight 10.x compatibility

christopheml opened this issue 2 years ago · 21 comments

christopheml commented 2 years ago

Much have changed in how the UI works under the hood with this patch and the addon currently does not work in Dragonflight.

Find a way to make it compatible.

christopheml · Answer 1 · 2022-11-08T11:15:25.000Z

Hello, just a little update on the status of this addon.

First of all, thanks to everyone here that contributed logs, info and a fix to the compatibility issue. I have been away from World of Warcraft and addon development for a while and still don't have much time, but I'll try to patch things up in the upcoming weekend.

Be well!

reiyooki · Answer 2 · 2022-10-28T21:35:51.000Z

In regards to this, here's the only error I'm seeing in BugSack at the moment (Though the tab also just doesn't show up in the collection pane)

48x bad argument #3 to '?' (Usage: local texture = self:CreateTexture([name, drawLayer, templateName, subLevel]))
[string "=[C]"]: in function `CreateTexture'
[string "@Interface/AddOns/SoulshapeJournal/UI/SoulshapeJournal.lua"]:185: in function <...face/AddOns/SoulshapeJournal/UI/SoulshapeJournal.lua:166>
[string "@Interface/AddOns/SoulshapeJournal/UI/SoulshapeJournal.lua"]:386: in function `CreateCollectionPanel'
[string "@Interface/AddOns/SoulshapeJournal/Core.lua"]:46: in function <Interface/AddOns/SoulshapeJournal/Core.lua:38>
[string "=[C]"]: ?
[string "@Interface/AddOns/!KalielsTracker/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <...s/!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@Interface/AddOns/!KalielsTracker/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@Interface/AddOns/!KalielsTracker/Libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:626: in function <...s/!KalielsTracker/Libs/AceAddon-3.0/AceAddon-3.0.lua:611>

dblanch369 · Answer 3 · 2022-10-29T22:28:58.000Z

Well for starters, change out the libs for the updated Ace3 ones that was posted for 10.0.0....

crackityjo · Answer 4 · 2022-10-30T09:11:48.000Z

I replaced the SecureTabs-2.0.lua file with the updated version at https://github.com/Jaliborc/SecureTabs-2.0 and it works fine.

Masumia · Answer 5 · 2022-10-30T19:02:02.000Z

I replaced the SecureTabs-2.0.lua file with the updated version at https://github.com/Jaliborc/SecureTabs-2.0 and it works fine.

I did this, but it does not clear up the error reported by @reiyooki

Flanell88 · Answer 6 · 2022-11-02T09:06:30.000Z

I replaced the SecureTabs-2.0.lua file with the updated version at https://github.com/Jaliborc/SecureTabs-2.0 and it works fine.

Did this but the tab is still not visible in the collection panel.

dblanch369 · Answer 7 · 2022-11-02T14:22:59.000Z

wasn't visible for me either...

…

On Wed, Nov 2, 2022 at 5:06 AM Flanell88 ***@***.***> wrote: I replaced the SecureTabs-2.0.lua file with the updated version at https://github.com/Jaliborc/SecureTabs-2.0 and it works fine. Did this but the tab is still not visible in the collection panel. — Reply to this email directly, view it on GitHub <#61 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFQOVBNMQE75MJEBXEJJ6B3WGIVKDANCNFSM6AAAAAAQZ5AJRI> . You are receiving this because you commented.Message ID: ***@***.***>

crackityjo · Answer 8 · 2022-11-03T01:51:42.000Z

Sorry, I forgot I did make a couple changes to \UI\SoulshapeJournal.lua. I'm attaching my version. Below Line 184, there are a couple of calls to soulshapeInfo:CreateTexture. I changed "LOW" to "BACKGROUND".
SoulshapeJournal.zip

Adarel · Answer 9 · 2022-11-03T03:51:25.000Z

This fixed it for me, thx @crackityjo,

Flanell88 · Answer 10 · 2022-11-03T11:04:35.000Z

Sorry, I forgot I did make a couple changes to \UI\SoulshapeJournal.lua. I'm attaching my version. Below Line 184, there are a couple of calls to soulshapeInfo:CreateTexture. I changed "LOW" to "BACKGROUND". SoulshapeJournal.zip

This worked. Thank you very much.

mregeur · Answer 11 · 2022-11-03T18:23:15.000Z

@Flanell88 @Adarel : Did you use @crackityjo's version or did you just edit your own? I replaced the Secure-Tabs file with the one linked above and then replaced the Soulshapejournal LUA file with the one linked above as well. The tab still doesn't appear. How did you guys manage to fix it?

InvisiBilldotnet · Answer 12 · 2022-11-03T23:36:22.000Z

Updating SecureTabs-2.0 and changing the 3 instances of LOW to BACKGROUND in \UI\SoulshapeJournal.lua fixed it for me as well. Thanks!

Flanell88 · Answer 13 · 2022-11-04T09:55:10.000Z

@mregeur I used the one crackityjo posted just like you and it worked for me.

mregeur · Answer 14 · 2022-11-04T10:48:23.000Z

Thanks @Flanell88, I finally got it to work after completely removing the addon, reinstalling it and then doing the steps above. Guess something else was screwy with it. Thanks all!

dblanch369 · Answer 15 · 2022-11-05T02:00:55.000Z

Could someone package it up into a single working zip file and post it here?On Nov 4, 2022, at 6:48 AM, mregeur ***@***.***> wrote: Thanks @Flanell88, I finally got it to work after completely removing the addon, reinstalling it and then doing the steps above. Guess something else was screwy with it. Thanks all! —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>

Adarel · Answer 16 · 2022-11-05T02:07:03.000Z

SoulshapeJournal.zip
This should work for you.

eboethrasher · Answer 17 · 2022-11-09T16:42:43.000Z

OK, even after installing SecureTabs 2.0 and changing the LOWs to BACKGROUND, I am now getting this error:

Message: CreateFrame(): Couldn't find inherited node "CharacterFrameTabButtonTemplate"
Time: Wed Nov 9 11:39:20 2022
Count: 1
Stack: CreateFrame(): Couldn't find inherited node "CharacterFrameTabButtonTemplate"
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "=[C]"]: in function CreateFrame' [string "@Interface/AddOns/SecureTabs-2.0/SecureTabs-2.0.lua"]:40: in function Add'
[string "@Interface/AddOns/SoulshapeJournal/UI/SoulshapeJournal.lua"]:252: in function <...face/AddOns/SoulshapeJournal/UI/SoulshapeJournal.lua:251>
[string "@Interface/AddOns/SoulshapeJournal/UI/SoulshapeJournal.lua"]:396: in function CreateCollectionPanel' [string "@Interface/AddOns/SoulshapeJournal/Core.lua"]:46: in function <Interface/AddOns/SoulshapeJournal/Core.lua:38> [string "=[C]"]: ? [string "@Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua"]:66: in function <Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua:61> [string "@Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua"]:523: in function EnableAddon'
[string "@Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua"]:626: in function <Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua:611>
[string "=[C]"]: in function LoadAddOn' [string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:11123: in function LoadAddOn'
[string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:11139: in function BlizzardAPIHook' [string "@Interface/AddOns/ArkInventory/Core/ArkInventory.lua"]:2900: in function <Interface/AddOns/ArkInventory/Core/ArkInventory.lua:2869> [string "=[C]"]: ? [string "@Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua"]:66: in function <Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua:61> [string "@Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua"]:523: in function EnableAddon'
[string "@Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua"]:626: in function <Interface/AddOns/Ace3/AceAddon-3.0/AceAddon-3.0.lua:611>

Locals:

ArkInventory has never caused a problem before.

christopheml · Answer 18 · 2022-11-13T18:27:09.000Z

A 1.2.2 version has been released and is pending validation on CurseForge. If you don't want to wait, you can download it directly from GitHub: https://github.com/christopheml/soulshape-journal/releases/download/1.2.2/SoulshapeJournal-1.2.2.zip

It contains libraries updates, TOC bump to 100000 and removing the now invalid LOW texture strata. I'm going to test the compatibility with ArkInventory and I'll open a ticket if necessary. Thanks to everyone that contributed here ✌️

christopheml · Answer 19 · 2022-11-13T21:14:33.000Z

@eboethrasher There doesn't seem to be any issue with ArkInventory and SoulshapeJournal. The fact that ArkInventory show up in the error message is the byproduct of how Ace addons work. Please update the addon with the official release (here on GitHub or CurseForge) and tell me if the problem persists.

eboethrasher · Answer 20 · 2022-11-15T10:17:09.000Z

Everything is working totally fine now, thank you so much for updating this awesome addon for us!

…

On Sun, Nov 13, 2022 at 4:14 PM Christophe Michel ***@***.***> wrote: @eboethrasher <https://github.com/eboethrasher> There doesn't seem to be any issue with ArkInventory and SoulshapeJournal. The fact that ArkInventory show up in the error message is the byproduct of how Ace addons work. Please update the addon with the official release (here on GitHub or CurseForge) and tell me if the problem persists. — Reply to this email directly, view it on GitHub <#61 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4CVLPHOJS6WAEZZT4JKH6TWIFK4JANCNFSM6AAAAAAQZ5AJRI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Thanks, Gary Thrasher

christopheml · Answer 21 · 2022-11-15T11:48:32.000Z

That's great to hear, thank you ❤️
Closing this.

Share to